2026-05-21 10:42:27 +00:00
package sessioncmd
import (
"context"
"fmt"
"strings"
"github.com/spf13/cobra"
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
"github.com/Tencent/WeKnora/cli/internal/iostreams"
"github.com/Tencent/WeKnora/cli/internal/output"
"github.com/Tencent/WeKnora/cli/internal/sse"
sdk "github.com/Tencent/WeKnora/client"
)
2026-06-20 18:41:36 +00:00
// sessionAskFields enumerates the fields surfaced for `--jq` projection
// discovery on `session ask`: the json object's data fields + the raw SDK
// agent event vocabulary used by --format ndjson.
2026-05-21 10:42:27 +00:00
var sessionAskFields = [ ] string {
2026-06-20 18:41:36 +00:00
"events" , "session_id" , "agent_id" , "query" ,
// NDJSON init + SDK event fields.
"type" , "profile" , "response_type" , "content" , "done" , "knowledge_references" , "data" ,
2026-05-21 10:42:27 +00:00
}
// AskOptions captures `session ask` flag state.
type AskOptions struct {
AgentID string
Query string
SessionID string // --session: continue an existing session (skip auto-create)
2026-06-20 18:41:36 +00:00
// Reference adds bounded kb_id/chunk_id reference events to JSON/text.
Reference bool
// Verbose surfaces the projected execution trace in JSON/text,
// including reasoning, tools, and lifecycle events.
// NDJSON is always raw and is unaffected by presentation flags.
Verbose bool
2026-05-21 10:42:27 +00:00
}
// AskService is the narrow SDK surface this command depends on.
//
// CreateSession is called when --session is omitted — sessions are
// agent-agnostic at creation (verified against
// internal/handler/session/handler.go CreateSession, which only persists
// {title, description}). The agent ID is supplied per-request via
// AgentQARequest.AgentID, so the same session can be reused across
// agent / KB-chat invocations.
type AskService interface {
CreateSession ( ctx context . Context , req * sdk . CreateSessionRequest ) ( * sdk . Session , error )
AgentQAStreamWithRequest ( ctx context . Context , sessionID string , req * sdk . AgentQARequest , cb sdk . AgentEventCallback ) error
}
// NewCmdAsk builds `weknora session ask --agent <agent-id> "<text>"`.
func NewCmdAsk ( f * cmdutil . Factory ) * cobra . Command {
opts := & AskOptions { }
cmd := & cobra . Command {
Use : ` ask "<text>" ` ,
Short : "Ask a server-side agent in a session context" ,
Long : ` Invoke a server - side agent within a session . If -- session is omitted ,
a new session is auto - created and its id is reported in the output for
the caller to thread follow - ups .
AI agents : this is the primary entrypoint for invoking custom agents .
The ' weknora agent ' subtree handles CRUD only ( list / view / create /
feat(cli)!: v0.10 reliability, agent-UX, and command-surface hardening
A hardening + finalization pass over the agent-first CLI: correctness fixes,
richer machine-readable signals, flag/naming consistency, and a symmetric
config surface. Pre-1.0, so it includes breaking renames.
Correctness:
- agent update: resolve/validate --model/--rerank-model (was storing a bogus
name verbatim, corrupting config.model_id).
- doctor: honor WEKNORA_HOST / WEKNORA_API_KEY (headless path no longer reports
"no host configured").
- session ask / MCP session_ask: text answer was empty on non-TTY — the agent
stream sets Done=true on an intermediate agent_query frame before the answer,
and AgentAccumulator treated the first Done as terminal. Terminate on the
`complete` event (new sdk.AgentResponseTypeComplete), not a per-frame Done.
- batch exit codes: any per-item failure collapses to operation.failed (exit 1),
including `doc upload --recursive` partial failures — a permanent per-file
failure (e.g. a duplicate) no longer surfaces as a retryable exit 7 an agent
would loop on; per-item typed errors stay in the envelope.
Agent-first signals & discovery:
- error.exit_code in the envelope (type + exit_code disambiguate the
input.invalid_argument exit-2-vs-5 split in one JSON read).
- meta.hint on empty content search and on draft doc create; doc wait fails fast
on a never-parsing draft instead of hanging to --timeout.
- retrieval-readiness is visible in the natural flow: kb status / kb check emit
retrieval_ready, and kb create hints the fix when no embedding model is bound
— an unconfigured KB no longer looks silently healthy.
- schema contract completeness: every leaf declares output + >=1 example
(drift-guarded); output strings match the meta actually emitted; chunk list
and search docs now emit meta.total_count (both previously dropped it).
- schema tolerates a quoted multi-word command label; zero-state auth — and
`link` with no profile — point at profile setup / the headless WEKNORA_KB_ID
path instead of looping on `auth login`.
- id-addressed reads tolerate a redundant --kb (doc view/wait, chunk list/view
accept and ignore it, declared in schema) so a carried-over --kb doesn't
exit 2; streaming commands warn that --jq does not apply to an NDJSON stream.
- keep JSON-always as the default; --jq hints spell out the .data path.
Consistency & gating:
- doc create: drop the deprecated --name alias (--title only; pre-1.0 break).
- chunk list --limit aligned to 1..10000; model list --limit/-L with
has_more/total_count; api write-gates -X PUT/PATCH (exit 10); skills install
expands a leading ~.
- docs corrected: search docs / doc list --keyword help is case-insensitive
(server does LOWER LIKE); AGENTS.md risk-action list (no phantom kb.init; add
model.update / kb.config.set) and batch example (failed item carries `error`);
session resume --message id comes from `message list`, not the stream.
- auth/profile ergonomics: env credentials are now first-class — `auth token`
prints the active WEKNORA_API_KEY / WEKNORA_TOKEN, and auth login/logout/refresh
give an env-aware message instead of looping on "run auth login". `auth logout`
clears credentials but keeps the profile registered (host preserved for
re-login); deleting a profile is `profile remove`'s job (clean logout/remove
separation, matching gh / lark).
Config surface (symmetric read/write, in-place model edits):
- kb config now returns a secret-free KBModelConfigView (was {}); `kb config`
reads, new `kb config set` writes; `kb init` removed (misnomer).
- kb create --chat-model: retrieval-ready in one step.
- model update: edit a model in place (id preserved, references survive) —
rotate --api-key-stdin, change base-url / display-name / etc.
- session continue-stream renamed to session resume.
Docs: AGENTS.md is the single wire-contract source; CHANGELOG slimmed; stale
kb-init / continue-stream references removed; skill wire-vocab guard extended.
AGENTS.md / weknora-shared SKILL document retrieval_ready (a KB needs an
embedding model to be searchable), that --jq does not apply to NDJSON
streams, and the env-credential-first auth path; the KB quickstart example
now creates a retrieval-ready KB.
2026-07-02 07:53:51 +00:00
update / delete / status / check ) .
2026-05-21 10:42:27 +00:00
Modes :
2026-06-20 18:41:36 +00:00
-- format json ( default ) : one JSON envelope with answer events
-- format text : live human - readable answer stream
-- format ndjson : raw NDJSON event stream — init line ( session_id ,
agent_id ) then SDK agent events verbatim . Debug .
Pass -- reference to include bounded kb_id / chunk_id reference indexes . Pass
-- verbose to include reasoning , tool activity , and lifecycle frames . Combine
both flags for the complete projected stream . ` ,
2026-05-21 10:42:27 +00:00
Example : ` weknora session ask -- agent ag_x "Summarize Q3 sales"
weknora session ask -- session sess_x -- agent ag_x "Follow-up question"
weknora session ask -- agent ag_x "Multi-step task" -- format ndjson ` ,
Args : cobra . ExactArgs ( 1 ) ,
RunE : func ( c * cobra . Command , args [ ] string ) error {
fopts , err := cmdutil . CheckFormatFlag ( c )
if err != nil {
return err
}
fopts . ResolveDefault ( iostreams . IO . IsStdoutTTY ( ) )
opts . Query = strings . TrimSpace ( args [ 0 ] )
cli , err := f . Client ( )
if err != nil {
return err
}
return runAsk ( c . Context ( ) , opts , fopts , cli )
} ,
}
cmd . Flags ( ) . StringVarP ( & opts . AgentID , "agent" , "a" , "" , "Agent ID to invoke (required)" )
_ = cmd . MarkFlagRequired ( "agent" )
cmd . Flags ( ) . StringVar ( & opts . SessionID , "session" , "" , "Continue an existing chat session (skip auto-create)" )
2026-06-20 18:41:36 +00:00
cmd . Flags ( ) . BoolVar ( & opts . Reference , "reference" , false , "Include indexed references in JSON/text output" )
cmd . Flags ( ) . BoolVar ( & opts . Verbose , "verbose" , false , "Include reasoning, tools, and lifecycle events in JSON/text output" )
2026-05-21 10:42:27 +00:00
cmdutil . AddFormatFlag ( cmd , sessionAskFields ... )
cmdutil . SetAgentHelp ( cmd , cmdutil . AgentHelp {
2026-06-20 18:41:36 +00:00
UsedFor : "Invoke a custom agent in a session context. Default JSON returns a bounded answer-event projection. --reference adds indexed citations; --verbose adds reasoning, tools, and lifecycle events. --format ndjson streams raw SDK agent events; --format text renders the selected events live." ,
2026-06-26 12:40:59 +00:00
RequiredFlags : [ ] string { "<text> (positional)" , "--agent" } ,
2026-05-21 10:42:27 +00:00
Examples : [ ] string {
2026-06-20 18:41:36 +00:00
` weknora session ask --agent ag_x "Summarize Q3 sales" ` ,
` weknora session ask --agent ag_x "Summarize Q3 sales" --jq '[.data.events[].content] | join("")' ` ,
` weknora session ask --session sess_x --agent ag_x "Follow-up question" ` ,
2026-05-21 10:42:27 +00:00
} ,
2026-06-20 18:41:36 +00:00
Output : "Default --format json: {ok,data:{events:[answer...],session_id,agent_id,query}}. --reference adds kb_id/chunk_id reference events; --verbose adds execution events. --format ndjson remains raw." ,
2026-05-21 10:42:27 +00:00
} )
return cmd
}
func runAsk ( ctx context . Context , opts * AskOptions , fopts * cmdutil . FormatOptions , svc AskService ) error {
if opts . Query == "" {
return cmdutil . NewError ( cmdutil . CodeInputInvalidArgument , "query argument cannot be empty" )
}
if opts . AgentID == "" {
return cmdutil . NewError ( cmdutil . CodeInputInvalidArgument , "agent-id argument cannot be empty" )
}
if svc == nil {
return cmdutil . NewError ( cmdutil . CodeServerError , "session ask: no SDK client available" )
}
2026-06-20 18:41:36 +00:00
// --format selects the output shape: json (default) accumulates and
// emits one object, ndjson streams raw SDK agent events, text renders.
2026-05-21 10:42:27 +00:00
sessionID := opts . SessionID
autoCreated := false
if sessionID == "" {
sess , err := svc . CreateSession ( ctx , & sdk . CreateSessionRequest { Title : "weknora session ask" } )
if err != nil {
if cmdutil . IsCancelled ( ctx , err ) {
return cmdutil . Wrapf ( cmdutil . CodeOperationCancelled , err , "session ask cancelled" )
}
code := cmdutil . ClassifyHTTPError ( err )
if code == cmdutil . CodeNetworkError || code == cmdutil . CodeServerError {
code = cmdutil . CodeSessionCreateFailed
}
return cmdutil . Wrapf ( code , err , "create chat session" )
}
sessionID = sess . ID
autoCreated = true
}
2026-06-20 18:41:36 +00:00
if fopts != nil && fopts . Mode == cmdutil . FormatNDJSON {
2026-05-21 10:42:27 +00:00
return runAskNDJSON ( ctx , opts , sessionID , svc )
}
2026-06-20 18:41:36 +00:00
if fopts != nil && fopts . Mode == cmdutil . FormatJSON {
return runAskJSON ( ctx , opts , fopts , sessionID , svc )
}
2026-05-21 10:42:27 +00:00
// Surface auto-created session id up-front so a ^C mid-stream still
2026-06-20 18:41:36 +00:00
// leaves a recoverable pointer. Skipped in json/ndjson mode (session_id
// is in the output).
2026-05-21 10:42:27 +00:00
if autoCreated {
fmt . Fprintf ( iostreams . IO . Err , "session: %s (use --session to continue)\n" , sessionID )
}
2026-05-21 10:43:18 +00:00
return runAskText ( ctx , opts , sessionID , autoCreated , svc )
2026-05-21 10:42:27 +00:00
}
2026-06-20 18:41:36 +00:00
// runAskNDJSON handles the --format ndjson path: emits a CLI init event at
// stream head, then passes every SDK agent event through verbatim as NDJSON
// lines. No buffering.
2026-05-21 10:42:27 +00:00
func runAskNDJSON ( ctx context . Context , opts * AskOptions , sessionID string , svc AskService ) error {
w := iostreams . IO . Out
refactor(cli): finish context→profile cascade + post-review hardening (BREAKING)
Post-review polish on the v0.7 wire / surface contract. Bundles five
follow-ups that landed after the main BREAKING feat commit:
1. Complete context→profile cascade (internal API + YAML schema)
The prior commit renamed only the user-visible surface (commands /
flags / env / project link / envelope field). The internal Go API
and on-disk config schema were still half-renamed — an L-25
self-consistency violation flagged by post-merge review. Closed here:
Internal Go API:
- config.Context → config.Profile
- config.Config.CurrentContext → CurrentProfile
- config.Config.Contexts → Profiles
- LoginOptions.Context → LoginOptions.Profile
- clearContextSecrets() → clearProfileSecrets()
- saveContextRef() → saveProfileRef()
- secrets.Store: param name `context` → `profile` (interface +
FileStore + KeyringStore + MemStore)
- cmdutil.LoadSecret(store, context, key) → LoadSecret(store, profile, key)
- cmdutil.RefreshAndPersist's ctxName → profileName
- Local var `ctx := &config.Profile{...}` → `prof := &config.Profile{...}`
in auth/login.go to eliminate the visual collision with Go stdlib
context.Context that motivated the whole rename in the first place.
On-disk config.yaml schema:
- current_context: → current_profile:
- contexts: → profiles:
- Pre-1.0 break, no compat alias. Users on v0.6 dogfooded configs
must delete ~/.config/weknora/config.yaml or hand-rename the two
keys (CHANGELOG migration note added).
Tests / fixtures / golden files:
- factory_test.go YAML fixture + assertion updated.
- acceptance/e2e/e2e_test.go writeContextYAML → writeProfileYAML,
fixture YAML keys updated.
- acceptance/testdata/wire/doctor.error_network.json golden updated
("active context" → "active profile" in hint string).
User-visible prose sweep:
- cmd/mcp/serve.go --help Long: "active context (or --context)" →
"active profile (or --profile)" — most-visible miss.
- cmd/{kb/list, search/kb, session/list, api/api} Short/Long help.
- cmd/auth/login.go stdout: `(context=%s)` → `(profile=%s)`.
- cmd/auth/logout.go error: `"no current context"` → `"no current profile"`.
- cmd/doctor/doctor.go hint string (also the wire golden above).
- cmd/auth/refresh.go error: `"refresh token missing for context"` →
`"refresh token missing for profile"`.
- README.md: `## Multi-context` H2 → `## Multi-profile`; code-block
comment `# current context` → `# current profile`.
Code-comment / docstring sweep across cli/cmd/auth/ and
cli/internal/cmdutil/. Comments referencing Go stdlib context.Context,
the RAG / LLM "context window" concept, and historical CHANGELOG
entries for v0.4 / v0.5 were left alone.
CHANGELOG v0.7 BREAKING entry gains the on-disk-schema bullet under
the existing "context → profile" item.
2. Profile name validation (shell-injection guard)
`envelope.error.retry_command` is a single shell-string field. An
AI agent that exec()s it via `sh -c <retry_command>` was injectable
through a maliciously-named profile:
weknora auth logout --name 'x; rm -rf ~'
# would produce: retry_command = "weknora auth logout --name x; rm -rf ~ -y"
`cmd/profile/add.go` already enforced an alphanumeric + `-_.`
allowlist via `validateName`. The `auth login` and `auth logout`
paths bypassed it.
- Moved validation from `cmd/profile/add.go` to
`cli/internal/cmdutil/profilename.go` as exported
`ValidateProfileName` (cmdutil is the import-cycle-safe home;
internal/config can't depend on cmdutil).
- `auth login` runs the validator before any persist call.
- `auth logout` runs the validator on `opts.Name` before
constructing `retry_command`.
- Unit tests (`profilename_test.go`) cover the allowlist, empty
rejection, path-traversal, shell metacharacters (`;`, `&`, `|`,
`$()`, backticks, quotes, whitespace, glob, redirects), and the
user-facing hint text. The shell-metachar test exists as a
regression guard.
Wire shape (`retry_command` string → `retry_command_argv []string`)
remains a v0.8 additive change per ROADMAP — this fix removes the
practical exploit path without touching the wire contract.
3. AI-agent terminology disambiguation
"agent" has three referents in this codebase: (a) WeKnora's
server-side Custom Agent resource, (b) the removed `agent invoke`
verb, (c) external LLM/automation consumers. Per project memory
feedback_no_meta_disambiguation_in_docs, the fix is full-term
naming, not "X has N meanings" prose. Surgical changes at section
headers + ambiguous prose:
- AGENTS.md: "Agent decision shortcuts" → "AI agent decision
shortcuts"; "agent-callable surface" → "AI-agent-callable
surface".
- README.md: "Designed to be agent-first" → "AI-agent-first";
"Other agent ergonomics" → "Other AI-agent ergonomics"; "in
agent contexts" → "in AI-agent contexts"; "for CI / agents" →
"for CI / AI agents".
Anaphoric "agents" inside paragraphs that already established
"AI agents" was left alone — full substitution everywhere would
have been prose noise without clarity gain.
4. Wire-contract review follow-ups
Real findings from a second-pass review of the v0.7 envelope /
streaming / surface design. Per project memory
feedback_check_in_domain_anchor_first, candidate findings were
first verified against the in-domain peer CLI explicitly cited as
the envelope anchor; two earlier-flagged issues turned out to be
in-pattern and were withdrawn.
Surviving fixes:
- AGENTS.md success-envelope example rewritten. The prior example
showed `has_more: false` / `_notice: {}` as if they were always
present, but both fields are `omitempty` and never serialize
when zero / nil. Replaced with three realistic shapes (list /
single resource / mutation with no payload) and added a note
that optional fields are omitted when empty.
- cmd/chat/chat.go Args: MinimumNArgs(1) → ExactArgs(1).
v0.6 silently joined `weknora chat hello world` into
`"hello world"`. v0.7 now rejects multi-arg with exit 2,
matching `weknora session ask`. BREAKING; CHANGELOG entry
added under v0.7 BREAKING.
- internal/output/envelope.go extracts NewEnvelope(data, meta,
profile) constructor. The jq-filter path in
cmdutil.FormatOptions.Emit was manually rebuilding the
envelope literal alongside the canonical WriteEnvelope path —
drift risk when fields are added. Single construction point now.
- internal/cmdutil/factory.go adds AddKBFlag(cmd) helper.
Five files (chat, doc/list, doc/upload, doc/create, doc/fetch)
had verbatim-identical `cmd.Flags().String("kb", ...)`
declarations. Centralised so flag name + help text stay
in sync with Factory.ResolveKB. Docstring reordering + gofmt
fixup landed in the same edit to keep ResolveKB's own godoc
attached to its function.
5. OSS-readiness comment / doc sweep
Pre-publication scrub of code, comments, and shipped Markdown to
remove references that only make sense in the development repo:
- AGENTS.md "Deliberate deviations + mainstream alignments"
section: removed peer-project name-drops from the comparison
table; rewrote as five flagged design decisions with rationale
but no specific competitor named. The four rows that previously
contrasted against a named peer CLI now state WeKnora's choice
+ rationale directly. Section header renamed to "Design
decisions worth flagging" since it is no longer a
deviation/alignment matrix.
- CHANGELOG v0.7 BREAKING rationales: three references to a
named peer CLI removed; the context→profile rationale now
cites only mainstream multi-credential CLIs by category (AWS /
Stripe / OpenAI / Anthropic), and the `api -d/--data` removal
rationale cites only `gh api` / `curl`. `chat` BREAKING entry
rationale similarly simplified.
- 35 cross-references to design-spec section numbers (§4.1 /
§4.5 / §5.3 etc.) removed from Go doc comments and test
comments across 13 files. The referenced spec lives outside
the shipped tree; readers of the public repo cannot resolve
them. Each reference replaced with a self-contained semantic
description (e.g. "the batch envelope" / "AGENTS.md section
on the success path").
- Mixed-language strings translated to English:
- Four Go comments: internal/cmdutil/exit.go:213,215,
internal/cmdutil/errors.go:156,
internal/output/batch_test.go:90,
internal/output/envelope_test.go:27.
- One CHANGELOG section title:
`v0.7 — Agent-first wire contract + 命令面集中清理` →
`... + command-surface cleanup`.
- CJK test fixtures (internal/text/truncate_test.go CJK
truncation cases, cmd/session/list_test.go Chinese session
title, acceptance/e2e/e2e_test.go Chinese RAG corpus)
retained — they are intentional test inputs, not stray prose.
- Makefile help comment: `golangci-lint added in PR-9` →
`golangci-lint planned`. Internal PR numbering should not
surface in shipped Makefile prose.
Build green, 28/28 packages, +5 new ValidateProfileName tests.
go vet / gofmt / go mod verify / go mod tidy all clean.
Rationale for the cascade: pre-1.0 is the cheapest moment to close
L-25 self-consistency (L-26). The half-finished internal rename
would have perpetuated the very `context` vs `context.Context`
ambiguity that motivated v0.7's user-visible rename in the first
place.
2026-05-21 15:44:16 +00:00
// 1. Inject the CLI-managed init event at the head of the stream.
2026-05-21 10:42:27 +00:00
// Carries session pointer + agent id callers need for follow-up threading.
initEv := output . InitEvent {
SessionID : sessionID ,
AgentID : opts . AgentID ,
Profile : cmdutil . GetProfile ( ) ,
}
if err := output . EmitInit ( w , initEv ) ; err != nil {
return err
}
// 2. Open SDK stream and pass each agent event through as a bare NDJSON line.
req := & sdk . AgentQARequest {
Query : opts . Query ,
AgentEnabled : true ,
AgentID : opts . AgentID ,
Channel : "api" ,
}
cb := func ( r * sdk . AgentStreamResponse ) error {
2026-06-20 18:41:36 +00:00
// NDJSON is the raw protocol/debug surface: do not filter events or
// mutate their payloads. JSON/text modes own presentation filtering.
2026-05-21 10:42:27 +00:00
return output . EmitSDKEvent ( w , r )
}
if err := svc . AgentQAStreamWithRequest ( ctx , sessionID , req , cb ) ; err != nil {
if cmdutil . IsCancelled ( ctx , err ) {
return cmdutil . Wrapf ( cmdutil . CodeOperationCancelled , err , "session ask cancelled" )
}
2026-07-02 16:27:48 +00:00
return cmdutil . WrapStream ( err , "agent-chat stream" )
2026-05-21 10:42:27 +00:00
}
return nil
}
2026-06-20 18:41:36 +00:00
// runAskText handles the --format text path. It renders the same
// projection as JSON immediately for both terminals and pipes.
2026-05-21 10:43:18 +00:00
func runAskText ( ctx context . Context , opts * AskOptions , sessionID string , autoCreated bool , svc AskService ) error {
2026-05-21 10:42:27 +00:00
req := & sdk . AgentQARequest {
Query : opts . Query ,
AgentEnabled : true ,
AgentID : opts . AgentID ,
Channel : "api" ,
}
2026-06-20 18:41:36 +00:00
projector := sse . NewProjector ( opts . Verbose , opts . Reference , "" )
renderer := sse . NewTextRenderer ( iostreams . IO . Out , opts . Verbose )
2026-05-21 10:42:27 +00:00
cb := func ( r * sdk . AgentStreamResponse ) error {
2026-06-20 18:41:36 +00:00
event , include := projector . Agent ( r )
if ! include {
return nil
2026-05-21 10:42:27 +00:00
}
2026-06-20 18:41:36 +00:00
return renderer . Write ( event )
2026-05-21 10:42:27 +00:00
}
streamErr := svc . AgentQAStreamWithRequest ( ctx , sessionID , req , cb )
if streamErr != nil {
if autoCreated {
fmt . Fprintf ( iostreams . IO . Err , "session: %s (resume with --session %s)\n" , sessionID , sessionID )
}
if cmdutil . IsCancelled ( ctx , streamErr ) {
return cmdutil . Wrapf ( cmdutil . CodeOperationCancelled , streamErr , "session ask cancelled" )
}
2026-06-20 18:41:36 +00:00
if projector . Seen ( ) && ! projector . Done ( ) {
2026-05-21 10:42:27 +00:00
return cmdutil . Wrapf ( cmdutil . CodeSSEStreamAborted , streamErr , "stream aborted before completion" )
}
2026-07-02 16:27:48 +00:00
return cmdutil . WrapStream ( streamErr , "agent-chat stream" )
2026-05-21 10:42:27 +00:00
}
2026-06-20 18:41:36 +00:00
// Server closed cleanly but never sent a complete event — treat as aborted
2026-05-21 10:42:27 +00:00
// so agents don't silently emit a truncated answer as ok=true.
2026-06-20 18:41:36 +00:00
if ! projector . Done ( ) {
2026-05-21 10:42:27 +00:00
return cmdutil . NewError ( cmdutil . CodeSSEStreamAborted , "stream ended without a terminal event" )
}
2026-06-20 18:41:36 +00:00
return renderer . Close ( )
}
2026-05-21 10:42:27 +00:00
2026-06-20 18:41:36 +00:00
// runAskJSON handles the --format json path (the default): collect the
// projection and emit it in one normal success envelope.
func runAskJSON ( ctx context . Context , opts * AskOptions , fopts * cmdutil . FormatOptions , sessionID string , svc AskService ) error {
req := & sdk . AgentQARequest {
Query : opts . Query ,
AgentEnabled : true ,
AgentID : opts . AgentID ,
Channel : "api" ,
}
projector := sse . NewProjector ( opts . Verbose , opts . Reference , "" )
events := make ( [ ] sse . ProjectedEvent , 0 )
cb := func ( r * sdk . AgentStreamResponse ) error {
if event , include := projector . Agent ( r ) ; include {
events = append ( events , event )
2026-05-21 10:42:27 +00:00
}
2026-06-20 18:41:36 +00:00
return nil
}
if err := svc . AgentQAStreamWithRequest ( ctx , sessionID , req , cb ) ; err != nil {
if cmdutil . IsCancelled ( ctx , err ) {
return askStreamError ( cmdutil . Wrapf ( cmdutil . CodeOperationCancelled , err , "session ask cancelled" ) , sessionID )
2026-05-21 10:42:27 +00:00
}
2026-07-02 16:27:48 +00:00
return askStreamError ( cmdutil . WrapStream ( err , "agent-chat stream" ) , sessionID )
2026-06-20 18:41:36 +00:00
}
if ! projector . Done ( ) {
return askStreamError (
cmdutil . NewError ( cmdutil . CodeSSEStreamAborted , "stream ended without a terminal event" ) ,
sessionID ,
)
2026-05-21 10:42:27 +00:00
}
2026-06-20 18:41:36 +00:00
data := askResult {
Events : events ,
SessionID : sessionID ,
AgentID : opts . AgentID ,
Query : opts . Query ,
2026-05-21 10:42:27 +00:00
}
2026-06-20 18:41:36 +00:00
// Reaching here means fopts.Mode is FormatJSON (the only caller). Route
// through FormatOptions.Emit so --jq projection and the success-envelope
// contract apply. A nil fopts (direct-test entry) defaults to JSON.
if fopts == nil {
fopts = & cmdutil . FormatOptions { Mode : cmdutil . FormatJSON }
2026-05-21 10:42:27 +00:00
}
2026-06-20 18:41:36 +00:00
return fopts . Emit ( iostreams . IO . Out , data , nil )
2026-05-21 10:42:27 +00:00
}
2026-06-20 18:41:36 +00:00
func askStreamError ( err * cmdutil . Error , sessionID string ) * cmdutil . Error {
return err . WithDetail ( map [ string ] any { "session_id" : sessionID } )
}
// askResult is the --format json data payload. The projector controls default
// versus verbose coverage.
type askResult struct {
Events [ ] sse . ProjectedEvent ` json:"events" `
SessionID string ` json:"session_id" `
AgentID string ` json:"agent_id" `
Query string ` json:"query" `
2026-05-21 10:42:27 +00:00
}
// compile-time check: production SDK client satisfies AskService.
var _ AskService = ( * sdk . Client ) ( nil )