WeKnora/cli/internal/format/ndjson_test.go

68 lines
1.7 KiB
Go
Raw Normal View History

feat(cli): --format / NDJSON / chat & agent invoke / MCP / SetAgentHelp / signal-aware ctx / kb create --storage-provider Adds the structured-output and agent-help surface plus root-level signal handling so AI agents (and humans working through pipes) get a stable wire contract. * --format text|json|ndjson flag, registered per-command on outputs that need it; default text on TTY, json on pipe. --jq <expr> pairs with json / ndjson to filter or project. FormatOptions absorbs JQ; WantsJSON() helper for the JSON dispatch. * WriteNDJSON helper in internal/format/ (per ndjson.org: one JSON value per line, arrays split element-per-line, empty slice → zero bytes). * chat / agent invoke wire --format ndjson via SDK StreamResponse / AgentStreamResponse 1:1 passthrough. Both commands detect ctx.Cancelled in every stream + session-create path and emit a stable "operation.cancelled" code on Ctrl-C / SIGTERM. * main.go wires signal.NotifyContext(SIGINT, SIGTERM) into the root context so long-running commands run their cancellation cleanup (re-emit auto-created session id, etc); the process exits 130 when the context was signal-cancelled, matching Unix convention. * MCP chat / agent_invoke output schemas extended with thinking / tool_calls / assistant_message_id (server-side accumulated; MCP tools/call has no standard partial-response). doc_view and doc_download now use doc_id (not knowledge_id) so agents see a single id naming convention across all tools — matches the chunk_list / search_chunks schemas and the CLI's <doc-id> positional. * SetAgentHelp(cmd, AgentHelp{...}) — opt-in machine-friendly --help payload activated by WEKNORA_AGENT_HELP=1. Applied to chat / kb list. * kb create --storage-provider <local|minio|cos|tos|s3|oss|ks3> — sets the new KB's storage_provider_config.provider at creation time (server does not expose it on update). Required on self-hosted deployments where the server-side default doesn't pre-populate a provider — without it, subsequent doc upload returns a misleading "kb not found".
2026-05-17 17:37:47 +00:00
package format_test
import (
"bytes"
"strings"
"testing"
"github.com/Tencent/WeKnora/cli/internal/format"
)
func TestWriteNDJSON_ArraySplitsPerElement(t *testing.T) {
var buf bytes.Buffer
arr := []map[string]any{{"id": "1"}, {"id": "2"}, {"id": "3"}}
if err := format.WriteNDJSON(&buf, arr); err != nil {
t.Fatalf("WriteNDJSON: %v", err)
}
want := `{"id":"1"}` + "\n" + `{"id":"2"}` + "\n" + `{"id":"3"}` + "\n"
if buf.String() != want {
t.Errorf("got %q want %q", buf.String(), want)
}
}
func TestWriteNDJSON_SingleRecord(t *testing.T) {
var buf bytes.Buffer
rec := map[string]string{"id": "abc"}
if err := format.WriteNDJSON(&buf, rec); err != nil {
t.Fatalf("WriteNDJSON: %v", err)
}
want := `{"id":"abc"}` + "\n"
if buf.String() != want {
t.Errorf("got %q want %q", buf.String(), want)
}
}
func TestWriteNDJSON_EmptySlice(t *testing.T) {
var buf bytes.Buffer
if err := format.WriteNDJSON(&buf, []string{}); err != nil {
t.Fatalf("WriteNDJSON: %v", err)
}
if buf.String() != "" {
t.Errorf("got %q want empty", buf.String())
}
}
func TestWriteNDJSON_TypedSlice(t *testing.T) {
type item struct {
ID string `json:"id"`
}
var buf bytes.Buffer
if err := format.WriteNDJSON(&buf, []item{{ID: "x"}, {ID: "y"}}); err != nil {
t.Fatalf("WriteNDJSON: %v", err)
}
want := `{"id":"x"}` + "\n" + `{"id":"y"}` + "\n"
if buf.String() != want {
t.Errorf("got %q want %q", buf.String(), want)
}
}
func TestWriteNDJSON_NoHTMLEscape(t *testing.T) {
var buf bytes.Buffer
if err := format.WriteNDJSON(&buf, map[string]string{"k": "a<b>c&d"}); err != nil {
t.Fatalf("WriteNDJSON: %v", err)
}
if !strings.Contains(buf.String(), "a<b>c&d") {
t.Errorf("expected unescaped HTML chars, got %q", buf.String())
}
}