WeKnora/cli/cmd/session/session.go

29 lines
850 B
Go
Raw Normal View History

feat(cli): session subtree + kb edit / pin / empty Roadmap items 3-5 (session) and 3-6/7/8 (kb manage). cli/cmd/session/ (new package; sessioncmd to avoid shadowing stdlib): - session list: paginated table (ID/TITLE/UPDATED). --page / --page-size with 1..1000 validation. _meta.has_more from page*size < total. - session view <id>: prints metadata; non-empty fields only. Server timestamps arrive as strings; parsed best-effort as RFC3339. - session delete <id>: high-risk-write; exit-10 confirmation in non- TTY/--json paths; --dry-run emits envelope.risk + dry_run:true. cli/cmd/kb (extended): - kb edit <id> [--name N] [--description D]: at least one flag required; *string options so unset fields stay unset in the PUT body. SDK UpdateKnowledgeBaseRequest has no embedding_model field, so the roadmap's --embedding-model dropped. - kb pin <id> / kb unpin <id>: direct parity with gh issue pin / gh issue unpin (verified against gh manual). Idempotent: GetKnowledgeBase reads IsPinned, TogglePinKnowledgeBase fires only on state change. SDK KnowledgeBase struct gained the IsPinned field (server already returned it; SDK just hadn't modeled it — non-breaking additive). - kb empty <id>: high-risk-write; exit-10 confirmation; --dry-run. Returns deleted_count from the async clear response. weknora-specific operation; no mainstream parallel. Golden envelopes for kb_list and kb_view updated to include the new is_pinned field — strict-additive change. Cleanups surfaced by the post-commit reviewer round: - ConfirmPrompter promoted to cli/internal/testutil/ (4-copy threshold reached: context/remove, kb/delete, kb/empty, session/delete). kb/delete_test.go's pre-existing local copy left untouched per the upstream-respect convention. - kb pin/unpin idempotent no-op path no longer emits a write-class envelope. Added _meta.warnings "already {un}pinned — no server call made" and dropped the risk classification on the no-op branch. - doc list --page-size was unbounded while session list enforces 1..1000. Same validation added to doc list. 18 + 18 unit tests; e2e exit codes verified. Roadmap: 3-5, 3-6, 3-7, 3-8.
2026-05-12 15:34:33 +00:00
// Package sessioncmd holds `weknora session` command tree (list / view /
// delete / ask / continue-stream / stop) for chat history and agent invocation.
feat(cli): session subtree + kb edit / pin / empty Roadmap items 3-5 (session) and 3-6/7/8 (kb manage). cli/cmd/session/ (new package; sessioncmd to avoid shadowing stdlib): - session list: paginated table (ID/TITLE/UPDATED). --page / --page-size with 1..1000 validation. _meta.has_more from page*size < total. - session view <id>: prints metadata; non-empty fields only. Server timestamps arrive as strings; parsed best-effort as RFC3339. - session delete <id>: high-risk-write; exit-10 confirmation in non- TTY/--json paths; --dry-run emits envelope.risk + dry_run:true. cli/cmd/kb (extended): - kb edit <id> [--name N] [--description D]: at least one flag required; *string options so unset fields stay unset in the PUT body. SDK UpdateKnowledgeBaseRequest has no embedding_model field, so the roadmap's --embedding-model dropped. - kb pin <id> / kb unpin <id>: direct parity with gh issue pin / gh issue unpin (verified against gh manual). Idempotent: GetKnowledgeBase reads IsPinned, TogglePinKnowledgeBase fires only on state change. SDK KnowledgeBase struct gained the IsPinned field (server already returned it; SDK just hadn't modeled it — non-breaking additive). - kb empty <id>: high-risk-write; exit-10 confirmation; --dry-run. Returns deleted_count from the async clear response. weknora-specific operation; no mainstream parallel. Golden envelopes for kb_list and kb_view updated to include the new is_pinned field — strict-additive change. Cleanups surfaced by the post-commit reviewer round: - ConfirmPrompter promoted to cli/internal/testutil/ (4-copy threshold reached: context/remove, kb/delete, kb/empty, session/delete). kb/delete_test.go's pre-existing local copy left untouched per the upstream-respect convention. - kb pin/unpin idempotent no-op path no longer emits a write-class envelope. Added _meta.warnings "already {un}pinned — no server call made" and dropped the risk classification on the no-op branch. - doc list --page-size was unbounded while session list enforces 1..1000. Same validation added to doc list. 18 + 18 unit tests; e2e exit codes verified. Roadmap: 3-5, 3-6, 3-7, 3-8.
2026-05-12 15:34:33 +00:00
//
// Package name `sessioncmd` (not `session`) so callers can `import sdk
// "github.com/Tencent/WeKnora/client"` and use `sdk.Session` without
refactor(cli): command-surface rename — session ask / doc fetch / doc create / doc delete --all Three command renames consolidate the v0.7 verb table: - `weknora agent invoke` → `weknora session ask --agent <id>`. Server route POST /sessions/{session_id}/agent-qa is session- anchored, so the verb moves with it. `weknora agent` subtree keeps CRUD only (list / view / create / edit / delete / status / check). SDK call (AgentQAStreamWithRequest) preserved verbatim; only the command surface + flag layout move. - `weknora doc upload` split into three commands: - `weknora doc upload <file>` — local file (only). - `weknora doc fetch <url>` — server-side remote fetch (was `upload --from-url`). URL-only flags (--title / --file-type / --tag-id) move with the verb. - `weknora doc create --text` — direct text knowledge entry via server CreateManualKnowledge. - `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`. Atomic server ClearKnowledgeBaseContents (no list-then-delete race). Same exit-10 -y/--yes guard as other destructive verbs; unified through the extended ConfirmDestructive helper. Parent commands (agent, kb, doc, chunk, session, auth, profile, search) lose their explicit Args:NoArgs + Run:cmd.Help so the unknown-subcommand guard fires correctly — `weknora agent invoke ag_x q` now emits the typed input.unknown_subcommand envelope with detail.available[] instead of cobra's free-form exit-2 prose. Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
2026-05-21 10:42:27 +00:00
// shadowing - same hygiene as `profilecmd`.
feat(cli): session subtree + kb edit / pin / empty Roadmap items 3-5 (session) and 3-6/7/8 (kb manage). cli/cmd/session/ (new package; sessioncmd to avoid shadowing stdlib): - session list: paginated table (ID/TITLE/UPDATED). --page / --page-size with 1..1000 validation. _meta.has_more from page*size < total. - session view <id>: prints metadata; non-empty fields only. Server timestamps arrive as strings; parsed best-effort as RFC3339. - session delete <id>: high-risk-write; exit-10 confirmation in non- TTY/--json paths; --dry-run emits envelope.risk + dry_run:true. cli/cmd/kb (extended): - kb edit <id> [--name N] [--description D]: at least one flag required; *string options so unset fields stay unset in the PUT body. SDK UpdateKnowledgeBaseRequest has no embedding_model field, so the roadmap's --embedding-model dropped. - kb pin <id> / kb unpin <id>: direct parity with gh issue pin / gh issue unpin (verified against gh manual). Idempotent: GetKnowledgeBase reads IsPinned, TogglePinKnowledgeBase fires only on state change. SDK KnowledgeBase struct gained the IsPinned field (server already returned it; SDK just hadn't modeled it — non-breaking additive). - kb empty <id>: high-risk-write; exit-10 confirmation; --dry-run. Returns deleted_count from the async clear response. weknora-specific operation; no mainstream parallel. Golden envelopes for kb_list and kb_view updated to include the new is_pinned field — strict-additive change. Cleanups surfaced by the post-commit reviewer round: - ConfirmPrompter promoted to cli/internal/testutil/ (4-copy threshold reached: context/remove, kb/delete, kb/empty, session/delete). kb/delete_test.go's pre-existing local copy left untouched per the upstream-respect convention. - kb pin/unpin idempotent no-op path no longer emits a write-class envelope. Added _meta.warnings "already {un}pinned — no server call made" and dropped the risk classification on the no-op branch. - doc list --page-size was unbounded while session list enforces 1..1000. Same validation added to doc list. 18 + 18 unit tests; e2e exit codes verified. Roadmap: 3-5, 3-6, 3-7, 3-8.
2026-05-12 15:34:33 +00:00
package sessioncmd
import (
"github.com/spf13/cobra"
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
)
// NewCmd builds the `weknora session` parent command.
func NewCmd(f *cmdutil.Factory) *cobra.Command {
cmd := &cobra.Command{
Use: "session",
Short: "Manage chat sessions",
}
cmd.AddCommand(NewCmdList(f))
cmd.AddCommand(NewCmdView(f))
cmd.AddCommand(NewCmdDelete(f))
refactor(cli): command-surface rename — session ask / doc fetch / doc create / doc delete --all Three command renames consolidate the v0.7 verb table: - `weknora agent invoke` → `weknora session ask --agent <id>`. Server route POST /sessions/{session_id}/agent-qa is session- anchored, so the verb moves with it. `weknora agent` subtree keeps CRUD only (list / view / create / edit / delete / status / check). SDK call (AgentQAStreamWithRequest) preserved verbatim; only the command surface + flag layout move. - `weknora doc upload` split into three commands: - `weknora doc upload <file>` — local file (only). - `weknora doc fetch <url>` — server-side remote fetch (was `upload --from-url`). URL-only flags (--title / --file-type / --tag-id) move with the verb. - `weknora doc create --text` — direct text knowledge entry via server CreateManualKnowledge. - `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`. Atomic server ClearKnowledgeBaseContents (no list-then-delete race). Same exit-10 -y/--yes guard as other destructive verbs; unified through the extended ConfirmDestructive helper. Parent commands (agent, kb, doc, chunk, session, auth, profile, search) lose their explicit Args:NoArgs + Run:cmd.Help so the unknown-subcommand guard fires correctly — `weknora agent invoke ag_x q` now emits the typed input.unknown_subcommand envelope with detail.available[] instead of cobra's free-form exit-2 prose. Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
2026-05-21 10:42:27 +00:00
cmd.AddCommand(NewCmdAsk(f))
cmd.AddCommand(NewCmdContinueStream(f))
cmd.AddCommand(NewCmdStop(f))
feat(cli): session subtree + kb edit / pin / empty Roadmap items 3-5 (session) and 3-6/7/8 (kb manage). cli/cmd/session/ (new package; sessioncmd to avoid shadowing stdlib): - session list: paginated table (ID/TITLE/UPDATED). --page / --page-size with 1..1000 validation. _meta.has_more from page*size < total. - session view <id>: prints metadata; non-empty fields only. Server timestamps arrive as strings; parsed best-effort as RFC3339. - session delete <id>: high-risk-write; exit-10 confirmation in non- TTY/--json paths; --dry-run emits envelope.risk + dry_run:true. cli/cmd/kb (extended): - kb edit <id> [--name N] [--description D]: at least one flag required; *string options so unset fields stay unset in the PUT body. SDK UpdateKnowledgeBaseRequest has no embedding_model field, so the roadmap's --embedding-model dropped. - kb pin <id> / kb unpin <id>: direct parity with gh issue pin / gh issue unpin (verified against gh manual). Idempotent: GetKnowledgeBase reads IsPinned, TogglePinKnowledgeBase fires only on state change. SDK KnowledgeBase struct gained the IsPinned field (server already returned it; SDK just hadn't modeled it — non-breaking additive). - kb empty <id>: high-risk-write; exit-10 confirmation; --dry-run. Returns deleted_count from the async clear response. weknora-specific operation; no mainstream parallel. Golden envelopes for kb_list and kb_view updated to include the new is_pinned field — strict-additive change. Cleanups surfaced by the post-commit reviewer round: - ConfirmPrompter promoted to cli/internal/testutil/ (4-copy threshold reached: context/remove, kb/delete, kb/empty, session/delete). kb/delete_test.go's pre-existing local copy left untouched per the upstream-respect convention. - kb pin/unpin idempotent no-op path no longer emits a write-class envelope. Added _meta.warnings "already {un}pinned — no server call made" and dropped the risk classification on the no-op branch. - doc list --page-size was unbounded while session list enforces 1..1000. Same validation added to doc list. 18 + 18 unit tests; e2e exit codes verified. Roadmap: 3-5, 3-6, 3-7, 3-8.
2026-05-12 15:34:33 +00:00
return cmd
}