WeKnora/cli/cmd/doc/upload_recursive.go

215 lines
7.4 KiB
Go
Raw Normal View History

feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
package doc
import (
refactor(cli): command-surface rename — session ask / doc fetch / doc create / doc delete --all Three command renames consolidate the v0.7 verb table: - `weknora agent invoke` → `weknora session ask --agent <id>`. Server route POST /sessions/{session_id}/agent-qa is session- anchored, so the verb moves with it. `weknora agent` subtree keeps CRUD only (list / view / create / edit / delete / status / check). SDK call (AgentQAStreamWithRequest) preserved verbatim; only the command surface + flag layout move. - `weknora doc upload` split into three commands: - `weknora doc upload <file>` — local file (only). - `weknora doc fetch <url>` — server-side remote fetch (was `upload --from-url`). URL-only flags (--title / --file-type / --tag-id) move with the verb. - `weknora doc create --text` — direct text knowledge entry via server CreateManualKnowledge. - `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`. Atomic server ClearKnowledgeBaseContents (no list-then-delete race). Same exit-10 -y/--yes guard as other destructive verbs; unified through the extended ConfirmDestructive helper. Parent commands (agent, kb, doc, chunk, session, auth, profile, search) lose their explicit Args:NoArgs + Run:cmd.Help so the unknown-subcommand guard fires correctly — `weknora agent invoke ag_x q` now emits the typed input.unknown_subcommand envelope with detail.available[] instead of cobra's free-form exit-2 prose. Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
2026-05-21 10:42:27 +00:00
"cmp"
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
"context"
"fmt"
"io/fs"
"os"
"path/filepath"
fix(cli): preserve directory structure in doc upload --recursive (#3753) * fix(cli): preserve directory structure in doc upload --recursive `doc upload --recursive` passed an empty customFileName to CreateKnowledgeFromFile, so every file landed in the knowledge base root and the directory tree it was asked to walk was lost. The web UI's folder upload does not have this problem -- it passes the browser-supplied relative path, which the server splits into folder_path + file_name via types.SplitKnowledgeRelativePath. Pass the path relative to the walked directory instead. Files directly under that directory still send "" so the request stays byte-identical to the previous behaviour for the common flat-directory case; only nested files gain a folder prefix. - knowledgeRelativePath() converts to forward slashes (the server splits on "/", so Windows backslashes would not separate) and returns "" for paths outside the walked root rather than leaking a "../" chain into the folder tree. - The test double previously discarded customFileName with `_,` -- which is why this could regress with the suite green. It now records the value and two tests cover the nested and flat cases. * fix(cli): reject only the parent component in knowledgeRelativePath Review feedback on the recursive-upload folder path: - `strings.HasPrefix(rel, "..")` also rejected children whose name merely starts with dots, e.g. `..drafts/report.pdf`. Replaced with a component-wise check (`rel == ".."` or `".."+separator` prefix). - Root-level files must send ""; the guard now returns "" for `filepath.Dir(rel) == "."` explicitly rather than relying on the accidental prefix match to encode that rule. Covered by a `..drafts/report.pdf` case in TestUploadRecursive_PreservesFolderStructure. * test(cli): expect an empty name for root files in knowledgeRelativePath knowledgeRelativePath returns "" for files directly under the walked root, so the test must expect that. Also wrap an over-long line. --------- Co-authored-by: wizardchen <wizardchen@tencent.com>
2026-10-08 05:13:57 +00:00
"strings"
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
"github.com/Tencent/WeKnora/cli/internal/iostreams"
refactor(cli): command-surface rename — session ask / doc fetch / doc create / doc delete --all Three command renames consolidate the v0.7 verb table: - `weknora agent invoke` → `weknora session ask --agent <id>`. Server route POST /sessions/{session_id}/agent-qa is session- anchored, so the verb moves with it. `weknora agent` subtree keeps CRUD only (list / view / create / edit / delete / status / check). SDK call (AgentQAStreamWithRequest) preserved verbatim; only the command surface + flag layout move. - `weknora doc upload` split into three commands: - `weknora doc upload <file>` — local file (only). - `weknora doc fetch <url>` — server-side remote fetch (was `upload --from-url`). URL-only flags (--title / --file-type / --tag-id) move with the verb. - `weknora doc create --text` — direct text knowledge entry via server CreateManualKnowledge. - `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`. Atomic server ClearKnowledgeBaseContents (no list-then-delete race). Same exit-10 -y/--yes guard as other destructive verbs; unified through the extended ConfirmDestructive helper. Parent commands (agent, kb, doc, chunk, session, auth, profile, search) lose their explicit Args:NoArgs + Run:cmd.Help so the unknown-subcommand guard fires correctly — `weknora agent invoke ag_x q` now emits the typed input.unknown_subcommand envelope with detail.available[] instead of cobra's free-form exit-2 prose. Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
2026-05-21 10:42:27 +00:00
"github.com/Tencent/WeKnora/cli/internal/output"
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
)
refactor(cli): command-surface rename — session ask / doc fetch / doc create / doc delete --all Three command renames consolidate the v0.7 verb table: - `weknora agent invoke` → `weknora session ask --agent <id>`. Server route POST /sessions/{session_id}/agent-qa is session- anchored, so the verb moves with it. `weknora agent` subtree keeps CRUD only (list / view / create / edit / delete / status / check). SDK call (AgentQAStreamWithRequest) preserved verbatim; only the command surface + flag layout move. - `weknora doc upload` split into three commands: - `weknora doc upload <file>` — local file (only). - `weknora doc fetch <url>` — server-side remote fetch (was `upload --from-url`). URL-only flags (--title / --file-type / --tag-id) move with the verb. - `weknora doc create --text` — direct text knowledge entry via server CreateManualKnowledge. - `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`. Atomic server ClearKnowledgeBaseContents (no list-then-delete race). Same exit-10 -y/--yes guard as other destructive verbs; unified through the extended ConfirmDestructive helper. Parent commands (agent, kb, doc, chunk, session, auth, profile, search) lose their explicit Args:NoArgs + Run:cmd.Help so the unknown-subcommand guard fires correctly — `weknora agent invoke ag_x q` now emits the typed input.unknown_subcommand envelope with detail.available[] instead of cobra's free-form exit-2 prose. Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
2026-05-21 10:42:27 +00:00
// uploadedFile holds the server-side result for a successful per-file upload.
// Keyed by file path in the uploadResults map populated by the RunBatch closure.
type uploadedFile struct {
ID string
Name string
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
}
// runUploadRecursive walks dir, filters by Glob, and uploads each match
// sequentially. Per-file errors do NOT abort the walk - they accumulate
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
// and the final return aggregates them so the user sees the full picture
// in one run. Exit semantics: nil error on full success, a typed *cmdutil.Error
// when ≥1 file failed (the typed code mirrors the first failure's
// classification so callers can still branch).
func runUploadRecursive(ctx context.Context, opts *UploadOptions, fopts *cmdutil.FormatOptions, svc UploadService, kbID, dir string) error {
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
if opts.Name != "" {
return &cmdutil.Error{
Code: cmdutil.CodeInputInvalidArgument,
Message: "--name cannot be combined with --recursive (one name can't apply to N files)",
Hint: "drop --name or upload files one at a time",
}
}
feat(cli): doc/kb resource expansion — upload flags + list filters + view fields Closes deep-tuning gaps in v0.4-shipped doc / kb / session commands. Each command had multiple SDK fields the CLI silently hardcoded or omitted; this commit threads them through. doc upload: - --enable-multimodel (tri-state via NoOptDefVal): toggle multimodal extraction (PDF/DOCX image-to-text) per upload. Empty explicit value (e.g. --enable-multimodel="" from uninterpolated shell var) rejected as input.invalid_argument rather than silently coerced. - --metadata key=value (repeatable): attach arbitrary metadata - --channel <name> (default api, override for browser / wechat ingests) - URL mode gains --title / --file-type / --tag-id; URL-only flags rejected with input.invalid_argument when used without --from-url doc list filter flags: - --keyword (server-side LIKE — case-sensitive per PG) - --file-type / --source / --tag-id - --start-time / --end-time (RFC3339) search docs switches from client-side substring to server-side Keyword via ListKnowledgeWithFilter — smaller wire payload, but case-sensitivity shifts (documented in CHANGELOG + help text + Long). MCP doc_list schema gains the same 6 filter fields (parity with CLI). session view --full + --limit: loads chat history via LoadMessages SDK method. kb view human KV expanded: type / pinned / temporary / processing state + count / summary model / created timestamp. All omit-empty. doc view human KV expanded: title (when distinct from filename) / description / source / channel / summary_status / enable_status / tag_id / storage (human bytes) / file_hash (12-char prefix).
2026-05-15 18:38:48 +00:00
// Parse --metadata up front so a malformed value aborts before the
// first SDK call - otherwise a typo in `key=value` would only surface
// per-file as repeated identical errors.
meta, err := parseMetadataKV(opts.Metadata)
if err != nil {
return err
}
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
info, err := os.Stat(dir)
if err != nil {
if os.IsNotExist(err) {
return cmdutil.Wrapf(cmdutil.CodeUploadFileNotFound, err, "directory not found: %s", dir)
}
return cmdutil.Wrapf(cmdutil.CodeLocalFileIO, err, "stat %s", dir)
}
if !info.IsDir() {
return &cmdutil.Error{
Code: cmdutil.CodeInputInvalidArgument,
Message: fmt.Sprintf("not a directory: %s (drop --recursive to upload a single file)", dir),
}
}
// Sanity-check the pattern up front so a typo doesn't show up as "no
// files matched" per-file. Cobra populates --glob; tests pass it
// explicitly - no in-function default needed.
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
if _, err := filepath.Match(opts.Glob, ""); err != nil {
return &cmdutil.Error{
Code: cmdutil.CodeInputInvalidArgument,
Message: fmt.Sprintf("invalid --glob %q: %v", opts.Glob, err),
}
}
matches, err := walkMatches(dir, opts.Glob)
if err != nil {
return cmdutil.Wrapf(cmdutil.CodeLocalFileIO, err, "walk %s", dir)
}
if len(matches) == 0 {
if fopts.WantsJSON() {
refactor(cli): command-surface rename — session ask / doc fetch / doc create / doc delete --all Three command renames consolidate the v0.7 verb table: - `weknora agent invoke` → `weknora session ask --agent <id>`. Server route POST /sessions/{session_id}/agent-qa is session- anchored, so the verb moves with it. `weknora agent` subtree keeps CRUD only (list / view / create / edit / delete / status / check). SDK call (AgentQAStreamWithRequest) preserved verbatim; only the command surface + flag layout move. - `weknora doc upload` split into three commands: - `weknora doc upload <file>` — local file (only). - `weknora doc fetch <url>` — server-side remote fetch (was `upload --from-url`). URL-only flags (--title / --file-type / --tag-id) move with the verb. - `weknora doc create --text` — direct text knowledge entry via server CreateManualKnowledge. - `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`. Atomic server ClearKnowledgeBaseContents (no list-then-delete race). Same exit-10 -y/--yes guard as other destructive verbs; unified through the extended ConfirmDestructive helper. Parent commands (agent, kb, doc, chunk, session, auth, profile, search) lose their explicit Args:NoArgs + Run:cmd.Help so the unknown-subcommand guard fires correctly — `weknora agent invoke ag_x q` now emits the typed input.unknown_subcommand envelope with detail.available[] instead of cobra's free-form exit-2 prose. Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
2026-05-21 10:42:27 +00:00
// Empty batch: emit an all-success envelope with zero items.
return output.WriteBatchEnvelope(iostreams.IO.Out, nil, fopts.TTY, cmdutil.GetProfile())
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
}
fmt.Fprintf(iostreams.IO.Out, "(no files matched %q under %s)\n", opts.Glob, dir)
return nil
}
refactor(cli): command-surface rename — session ask / doc fetch / doc create / doc delete --all Three command renames consolidate the v0.7 verb table: - `weknora agent invoke` → `weknora session ask --agent <id>`. Server route POST /sessions/{session_id}/agent-qa is session- anchored, so the verb moves with it. `weknora agent` subtree keeps CRUD only (list / view / create / edit / delete / status / check). SDK call (AgentQAStreamWithRequest) preserved verbatim; only the command surface + flag layout move. - `weknora doc upload` split into three commands: - `weknora doc upload <file>` — local file (only). - `weknora doc fetch <url>` — server-side remote fetch (was `upload --from-url`). URL-only flags (--title / --file-type / --tag-id) move with the verb. - `weknora doc create --text` — direct text knowledge entry via server CreateManualKnowledge. - `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`. Atomic server ClearKnowledgeBaseContents (no list-then-delete race). Same exit-10 -y/--yes guard as other destructive verbs; unified through the extended ConfirmDestructive helper. Parent commands (agent, kb, doc, chunk, session, auth, profile, search) lose their explicit Args:NoArgs + Run:cmd.Help so the unknown-subcommand guard fires correctly — `weknora agent invoke ag_x q` now emits the typed input.unknown_subcommand envelope with detail.available[] instead of cobra's free-form exit-2 prose. Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
2026-05-21 10:42:27 +00:00
// uploaded captures per-path server results for successful uploads.
// Populated by the RunBatch closure; read by the resultFn below.
uploaded := make(map[string]uploadedFile, len(matches))
channel := cmp.Or(opts.Channel, uploadChannel)
outcomes, runErr := cmdutil.RunBatch(ctx, matches, func(ctx context.Context, p string) error {
fix(cli): preserve directory structure in doc upload --recursive (#3753) * fix(cli): preserve directory structure in doc upload --recursive `doc upload --recursive` passed an empty customFileName to CreateKnowledgeFromFile, so every file landed in the knowledge base root and the directory tree it was asked to walk was lost. The web UI's folder upload does not have this problem -- it passes the browser-supplied relative path, which the server splits into folder_path + file_name via types.SplitKnowledgeRelativePath. Pass the path relative to the walked directory instead. Files directly under that directory still send "" so the request stays byte-identical to the previous behaviour for the common flat-directory case; only nested files gain a folder prefix. - knowledgeRelativePath() converts to forward slashes (the server splits on "/", so Windows backslashes would not separate) and returns "" for paths outside the walked root rather than leaking a "../" chain into the folder tree. - The test double previously discarded customFileName with `_,` -- which is why this could regress with the suite green. It now records the value and two tests cover the nested and flat cases. * fix(cli): reject only the parent component in knowledgeRelativePath Review feedback on the recursive-upload folder path: - `strings.HasPrefix(rel, "..")` also rejected children whose name merely starts with dots, e.g. `..drafts/report.pdf`. Replaced with a component-wise check (`rel == ".."` or `".."+separator` prefix). - Root-level files must send ""; the guard now returns "" for `filepath.Dir(rel) == "."` explicitly rather than relying on the accidental prefix match to encode that rule. Covered by a `..drafts/report.pdf` case in TestUploadRecursive_PreservesFolderStructure. * test(cli): expect an empty name for root files in knowledgeRelativePath knowledgeRelativePath returns "" for files directly under the walked root, so the test must expect that. Also wrap an over-long line. --------- Co-authored-by: wizardchen <wizardchen@tencent.com>
2026-10-08 05:13:57 +00:00
// Path-qualified name so the server can rebuild the directory tree.
// CreateKnowledgeFromFile splits this into folder_path + file_name
// (types.SplitKnowledgeRelativePath), which is the same channel the web
// UI's folder upload uses. Passing "" here flattened every file into the
// KB root, losing the structure --recursive was asked to walk.
customFileName := knowledgeRelativePath(dir, p)
k, err := svc.CreateKnowledgeFromFile(ctx, kbID, p, meta, opts.EnableMultimodel, customFileName, channel, nil)
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
if err != nil {
fix(cli): plug v0.3 final review findings (json + auth + path + bounds + kb) Seven bugs surfaced via two audit rounds — parallel reviewer agents plus a real-server end-to-end demo. Each fix arrives with a regression test. 1. doc upload --recursive --json corrupted the envelope stream. Per-file FAIL/OK plain lines printed unconditionally to stdout, then a Success envelope, then on partial failure a typed error that the root handler turned into a SECOND Failure envelope — three outputs where one was expected. Fix: gate the plain lines behind !opts.JSONOut, and add cmdutil.Error.Silent so the JSON- path partial-failure preserves its typed exit code without triggering PrintErrorEnvelope's default Failure-envelope write. 2. auth refresh / AuthRetryTransport misclassified HTTP failures as network.error. RefreshAndPersist wrapped every refresher error with CodeNetworkError, but the SDK emits "HTTP error 401: ..." for a rejected refresh token — which should surface as auth.token_expired. Switched to WrapHTTP for proper status- derived classification. Affects both `auth refresh` and the transport's refresh closure. 3. doc download accepted ".." as a server-suggested filename. The rejection list covered "" / "." / filepath.Separator but not bare ".." — filepath.Base("..") is "..", which slipped through to os.Create and produced a confusing local.file_io wrap. Added to the rejection set. 4. search chunks / docs / kb / sessions had no lower bound on --limit. `-L 0` / `-L -1` was forwarded to the server with undefined behavior. Added a 1..1000 bound at the RunE boundary across all four (matching doc list / session list page-size bounds). Internal callers in tests can still pass Limit==0 for the "no client-side cap" runChunks path — the bound only applies at the user-input layer. 5. cli/AGENTS.md ADR-3 verb-canon summary listed only v0.2 verbs as "gh-canonical" and missed v0.3 additions (edit, pin, unpin, download — all gh-canonical) plus locally-introduced ones (empty, refresh, add, remove, link). Rewritten as an explicit gh-canonical / locally-introduced split. 6. kb pin returned 404. Server registers /knowledge-bases/{id}/pin as PUT (router.go:292); SDK was using POST. gin's router silently 404s on method-mismatch (treats it as path-not-found, not 405), so the CLI classified the response as resource.not_found and masked the real failure mode. Switched the SDK to http.MethodPut. The asymmetry that hid this past round 1: kb unpin on a freshly- created KB hits the no-op branch in cmd/kb/pin.go that skips the SDK call entirely, so unpin "worked" without ever exercising the broken path. Only the real-server demo, where kb pin actually fires, surfaced it. 7. kb edit clobbered current Name when only --description was passed. EditOptions used *string to distinguish "unset" from "set to empty", but sdk.UpdateKnowledgeBaseRequest declares both fields as plain string (no omitempty), so the JSON body always carried `"name": ""`. Server requires Name → 400. Fix: runEdit does fetch-then-update — GetKnowledgeBase first, build the PUT body with current values, then overlay user-set fields. Same TOCTOU window as kb pin / unpin. Audit-flagged items intentionally NOT changed: - kb pin / unpin check-then-toggle TOCTOU: documented; the clean fix would be a server-side setter and belongs in a separate API change. - AuthRetryTransport singleflight test gap for one concurrency scenario; v0.4 polish. - cli/README.md:50 "once v0.2 ships" and CHANGELOG.md:8 "10 top-level commands": v0.2-PR artifacts, not v0.3-introduced. - kb edit / kb pin are v0.3-new commands, so neither bug needs a cli/CHANGELOG.md Fixed entry — the v0.3 release ships them working as the Added bullets advertise.
2026-05-13 07:39:09 +00:00
// Per-file progress lines are human progress signal; suppress
// under --format json so they don't precede the JSON object on stdout.
if !fopts.WantsJSON() {
fix(cli): plug v0.3 final review findings (json + auth + path + bounds + kb) Seven bugs surfaced via two audit rounds — parallel reviewer agents plus a real-server end-to-end demo. Each fix arrives with a regression test. 1. doc upload --recursive --json corrupted the envelope stream. Per-file FAIL/OK plain lines printed unconditionally to stdout, then a Success envelope, then on partial failure a typed error that the root handler turned into a SECOND Failure envelope — three outputs where one was expected. Fix: gate the plain lines behind !opts.JSONOut, and add cmdutil.Error.Silent so the JSON- path partial-failure preserves its typed exit code without triggering PrintErrorEnvelope's default Failure-envelope write. 2. auth refresh / AuthRetryTransport misclassified HTTP failures as network.error. RefreshAndPersist wrapped every refresher error with CodeNetworkError, but the SDK emits "HTTP error 401: ..." for a rejected refresh token — which should surface as auth.token_expired. Switched to WrapHTTP for proper status- derived classification. Affects both `auth refresh` and the transport's refresh closure. 3. doc download accepted ".." as a server-suggested filename. The rejection list covered "" / "." / filepath.Separator but not bare ".." — filepath.Base("..") is "..", which slipped through to os.Create and produced a confusing local.file_io wrap. Added to the rejection set. 4. search chunks / docs / kb / sessions had no lower bound on --limit. `-L 0` / `-L -1` was forwarded to the server with undefined behavior. Added a 1..1000 bound at the RunE boundary across all four (matching doc list / session list page-size bounds). Internal callers in tests can still pass Limit==0 for the "no client-side cap" runChunks path — the bound only applies at the user-input layer. 5. cli/AGENTS.md ADR-3 verb-canon summary listed only v0.2 verbs as "gh-canonical" and missed v0.3 additions (edit, pin, unpin, download — all gh-canonical) plus locally-introduced ones (empty, refresh, add, remove, link). Rewritten as an explicit gh-canonical / locally-introduced split. 6. kb pin returned 404. Server registers /knowledge-bases/{id}/pin as PUT (router.go:292); SDK was using POST. gin's router silently 404s on method-mismatch (treats it as path-not-found, not 405), so the CLI classified the response as resource.not_found and masked the real failure mode. Switched the SDK to http.MethodPut. The asymmetry that hid this past round 1: kb unpin on a freshly- created KB hits the no-op branch in cmd/kb/pin.go that skips the SDK call entirely, so unpin "worked" without ever exercising the broken path. Only the real-server demo, where kb pin actually fires, surfaced it. 7. kb edit clobbered current Name when only --description was passed. EditOptions used *string to distinguish "unset" from "set to empty", but sdk.UpdateKnowledgeBaseRequest declares both fields as plain string (no omitempty), so the JSON body always carried `"name": ""`. Server requires Name → 400. Fix: runEdit does fetch-then-update — GetKnowledgeBase first, build the PUT body with current values, then overlay user-set fields. Same TOCTOU window as kb pin / unpin. Audit-flagged items intentionally NOT changed: - kb pin / unpin check-then-toggle TOCTOU: documented; the clean fix would be a server-side setter and belongs in a separate API change. - AuthRetryTransport singleflight test gap for one concurrency scenario; v0.4 polish. - cli/README.md:50 "once v0.2 ships" and CHANGELOG.md:8 "10 top-level commands": v0.2-PR artifacts, not v0.3-introduced. - kb edit / kb pin are v0.3-new commands, so neither bug needs a cli/CHANGELOG.md Fixed entry — the v0.3 release ships them working as the Added bullets advertise.
2026-05-13 07:39:09 +00:00
fmt.Fprintf(iostreams.IO.Out, "FAIL %s: %v\n", filepath.Base(p), err)
}
refactor(cli): command-surface rename — session ask / doc fetch / doc create / doc delete --all Three command renames consolidate the v0.7 verb table: - `weknora agent invoke` → `weknora session ask --agent <id>`. Server route POST /sessions/{session_id}/agent-qa is session- anchored, so the verb moves with it. `weknora agent` subtree keeps CRUD only (list / view / create / edit / delete / status / check). SDK call (AgentQAStreamWithRequest) preserved verbatim; only the command surface + flag layout move. - `weknora doc upload` split into three commands: - `weknora doc upload <file>` — local file (only). - `weknora doc fetch <url>` — server-side remote fetch (was `upload --from-url`). URL-only flags (--title / --file-type / --tag-id) move with the verb. - `weknora doc create --text` — direct text knowledge entry via server CreateManualKnowledge. - `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`. Atomic server ClearKnowledgeBaseContents (no list-then-delete race). Same exit-10 -y/--yes guard as other destructive verbs; unified through the extended ConfirmDestructive helper. Parent commands (agent, kb, doc, chunk, session, auth, profile, search) lose their explicit Args:NoArgs + Run:cmd.Help so the unknown-subcommand guard fires correctly — `weknora agent invoke ag_x q` now emits the typed input.unknown_subcommand envelope with detail.available[] instead of cobra's free-form exit-2 prose. Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
2026-05-21 10:42:27 +00:00
return err
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
}
refactor(cli): command-surface rename — session ask / doc fetch / doc create / doc delete --all Three command renames consolidate the v0.7 verb table: - `weknora agent invoke` → `weknora session ask --agent <id>`. Server route POST /sessions/{session_id}/agent-qa is session- anchored, so the verb moves with it. `weknora agent` subtree keeps CRUD only (list / view / create / edit / delete / status / check). SDK call (AgentQAStreamWithRequest) preserved verbatim; only the command surface + flag layout move. - `weknora doc upload` split into three commands: - `weknora doc upload <file>` — local file (only). - `weknora doc fetch <url>` — server-side remote fetch (was `upload --from-url`). URL-only flags (--title / --file-type / --tag-id) move with the verb. - `weknora doc create --text` — direct text knowledge entry via server CreateManualKnowledge. - `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`. Atomic server ClearKnowledgeBaseContents (no list-then-delete race). Same exit-10 -y/--yes guard as other destructive verbs; unified through the extended ConfirmDestructive helper. Parent commands (agent, kb, doc, chunk, session, auth, profile, search) lose their explicit Args:NoArgs + Run:cmd.Help so the unknown-subcommand guard fires correctly — `weknora agent invoke ag_x q` now emits the typed input.unknown_subcommand envelope with detail.available[] instead of cobra's free-form exit-2 prose. Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
2026-05-21 10:42:27 +00:00
id, name := "", ""
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
if k != nil {
id = k.ID
refactor(cli): command-surface rename — session ask / doc fetch / doc create / doc delete --all Three command renames consolidate the v0.7 verb table: - `weknora agent invoke` → `weknora session ask --agent <id>`. Server route POST /sessions/{session_id}/agent-qa is session- anchored, so the verb moves with it. `weknora agent` subtree keeps CRUD only (list / view / create / edit / delete / status / check). SDK call (AgentQAStreamWithRequest) preserved verbatim; only the command surface + flag layout move. - `weknora doc upload` split into three commands: - `weknora doc upload <file>` — local file (only). - `weknora doc fetch <url>` — server-side remote fetch (was `upload --from-url`). URL-only flags (--title / --file-type / --tag-id) move with the verb. - `weknora doc create --text` — direct text knowledge entry via server CreateManualKnowledge. - `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`. Atomic server ClearKnowledgeBaseContents (no list-then-delete race). Same exit-10 -y/--yes guard as other destructive verbs; unified through the extended ConfirmDestructive helper. Parent commands (agent, kb, doc, chunk, session, auth, profile, search) lose their explicit Args:NoArgs + Run:cmd.Help so the unknown-subcommand guard fires correctly — `weknora agent invoke ag_x q` now emits the typed input.unknown_subcommand envelope with detail.available[] instead of cobra's free-form exit-2 prose. Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
2026-05-21 10:42:27 +00:00
name = k.FileName
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
}
refactor(cli): command-surface rename — session ask / doc fetch / doc create / doc delete --all Three command renames consolidate the v0.7 verb table: - `weknora agent invoke` → `weknora session ask --agent <id>`. Server route POST /sessions/{session_id}/agent-qa is session- anchored, so the verb moves with it. `weknora agent` subtree keeps CRUD only (list / view / create / edit / delete / status / check). SDK call (AgentQAStreamWithRequest) preserved verbatim; only the command surface + flag layout move. - `weknora doc upload` split into three commands: - `weknora doc upload <file>` — local file (only). - `weknora doc fetch <url>` — server-side remote fetch (was `upload --from-url`). URL-only flags (--title / --file-type / --tag-id) move with the verb. - `weknora doc create --text` — direct text knowledge entry via server CreateManualKnowledge. - `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`. Atomic server ClearKnowledgeBaseContents (no list-then-delete race). Same exit-10 -y/--yes guard as other destructive verbs; unified through the extended ConfirmDestructive helper. Parent commands (agent, kb, doc, chunk, session, auth, profile, search) lose their explicit Args:NoArgs + Run:cmd.Help so the unknown-subcommand guard fires correctly — `weknora agent invoke ag_x q` now emits the typed input.unknown_subcommand envelope with detail.available[] instead of cobra's free-form exit-2 prose. Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
2026-05-21 10:42:27 +00:00
uploaded[p] = uploadedFile{ID: id, Name: name}
if !fopts.WantsJSON() {
fix(cli): plug v0.3 final review findings (json + auth + path + bounds + kb) Seven bugs surfaced via two audit rounds — parallel reviewer agents plus a real-server end-to-end demo. Each fix arrives with a regression test. 1. doc upload --recursive --json corrupted the envelope stream. Per-file FAIL/OK plain lines printed unconditionally to stdout, then a Success envelope, then on partial failure a typed error that the root handler turned into a SECOND Failure envelope — three outputs where one was expected. Fix: gate the plain lines behind !opts.JSONOut, and add cmdutil.Error.Silent so the JSON- path partial-failure preserves its typed exit code without triggering PrintErrorEnvelope's default Failure-envelope write. 2. auth refresh / AuthRetryTransport misclassified HTTP failures as network.error. RefreshAndPersist wrapped every refresher error with CodeNetworkError, but the SDK emits "HTTP error 401: ..." for a rejected refresh token — which should surface as auth.token_expired. Switched to WrapHTTP for proper status- derived classification. Affects both `auth refresh` and the transport's refresh closure. 3. doc download accepted ".." as a server-suggested filename. The rejection list covered "" / "." / filepath.Separator but not bare ".." — filepath.Base("..") is "..", which slipped through to os.Create and produced a confusing local.file_io wrap. Added to the rejection set. 4. search chunks / docs / kb / sessions had no lower bound on --limit. `-L 0` / `-L -1` was forwarded to the server with undefined behavior. Added a 1..1000 bound at the RunE boundary across all four (matching doc list / session list page-size bounds). Internal callers in tests can still pass Limit==0 for the "no client-side cap" runChunks path — the bound only applies at the user-input layer. 5. cli/AGENTS.md ADR-3 verb-canon summary listed only v0.2 verbs as "gh-canonical" and missed v0.3 additions (edit, pin, unpin, download — all gh-canonical) plus locally-introduced ones (empty, refresh, add, remove, link). Rewritten as an explicit gh-canonical / locally-introduced split. 6. kb pin returned 404. Server registers /knowledge-bases/{id}/pin as PUT (router.go:292); SDK was using POST. gin's router silently 404s on method-mismatch (treats it as path-not-found, not 405), so the CLI classified the response as resource.not_found and masked the real failure mode. Switched the SDK to http.MethodPut. The asymmetry that hid this past round 1: kb unpin on a freshly- created KB hits the no-op branch in cmd/kb/pin.go that skips the SDK call entirely, so unpin "worked" without ever exercising the broken path. Only the real-server demo, where kb pin actually fires, surfaced it. 7. kb edit clobbered current Name when only --description was passed. EditOptions used *string to distinguish "unset" from "set to empty", but sdk.UpdateKnowledgeBaseRequest declares both fields as plain string (no omitempty), so the JSON body always carried `"name": ""`. Server requires Name → 400. Fix: runEdit does fetch-then-update — GetKnowledgeBase first, build the PUT body with current values, then overlay user-set fields. Same TOCTOU window as kb pin / unpin. Audit-flagged items intentionally NOT changed: - kb pin / unpin check-then-toggle TOCTOU: documented; the clean fix would be a server-side setter and belongs in a separate API change. - AuthRetryTransport singleflight test gap for one concurrency scenario; v0.4 polish. - cli/README.md:50 "once v0.2 ships" and CHANGELOG.md:8 "10 top-level commands": v0.2-PR artifacts, not v0.3-introduced. - kb edit / kb pin are v0.3-new commands, so neither bug needs a cli/CHANGELOG.md Fixed entry — the v0.3 release ships them working as the Added bullets advertise.
2026-05-13 07:39:09 +00:00
fmt.Fprintf(iostreams.IO.Out, "OK %s (id: %s)\n", filepath.Base(p), id)
}
refactor(cli): command-surface rename — session ask / doc fetch / doc create / doc delete --all Three command renames consolidate the v0.7 verb table: - `weknora agent invoke` → `weknora session ask --agent <id>`. Server route POST /sessions/{session_id}/agent-qa is session- anchored, so the verb moves with it. `weknora agent` subtree keeps CRUD only (list / view / create / edit / delete / status / check). SDK call (AgentQAStreamWithRequest) preserved verbatim; only the command surface + flag layout move. - `weknora doc upload` split into three commands: - `weknora doc upload <file>` — local file (only). - `weknora doc fetch <url>` — server-side remote fetch (was `upload --from-url`). URL-only flags (--title / --file-type / --tag-id) move with the verb. - `weknora doc create --text` — direct text knowledge entry via server CreateManualKnowledge. - `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`. Atomic server ClearKnowledgeBaseContents (no list-then-delete race). Same exit-10 -y/--yes guard as other destructive verbs; unified through the extended ConfirmDestructive helper. Parent commands (agent, kb, doc, chunk, session, auth, profile, search) lose their explicit Args:NoArgs + Run:cmd.Help so the unknown-subcommand guard fires correctly — `weknora agent invoke ag_x q` now emits the typed input.unknown_subcommand envelope with detail.available[] instead of cobra's free-form exit-2 prose. Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
2026-05-21 10:42:27 +00:00
return nil
})
failures := 0
for _, oc := range outcomes {
if oc.Err != nil {
failures++
}
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
}
if fopts.WantsJSON() {
refactor(cli): command-surface rename — session ask / doc fetch / doc create / doc delete --all Three command renames consolidate the v0.7 verb table: - `weknora agent invoke` → `weknora session ask --agent <id>`. Server route POST /sessions/{session_id}/agent-qa is session- anchored, so the verb moves with it. `weknora agent` subtree keeps CRUD only (list / view / create / edit / delete / status / check). SDK call (AgentQAStreamWithRequest) preserved verbatim; only the command surface + flag layout move. - `weknora doc upload` split into three commands: - `weknora doc upload <file>` — local file (only). - `weknora doc fetch <url>` — server-side remote fetch (was `upload --from-url`). URL-only flags (--title / --file-type / --tag-id) move with the verb. - `weknora doc create --text` — direct text knowledge entry via server CreateManualKnowledge. - `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`. Atomic server ClearKnowledgeBaseContents (no list-then-delete race). Same exit-10 -y/--yes guard as other destructive verbs; unified through the extended ConfirmDestructive helper. Parent commands (agent, kb, doc, chunk, session, auth, profile, search) lose their explicit Args:NoArgs + Run:cmd.Help so the unknown-subcommand guard fires correctly — `weknora agent invoke ag_x q` now emits the typed input.unknown_subcommand envelope with detail.available[] instead of cobra's free-form exit-2 prose. Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
2026-05-21 10:42:27 +00:00
if err := cmdutil.EmitBatch(outcomes, fopts, iostreams.IO.Out, func(p string) any {
f := uploaded[p]
return map[string]any{"id": f.ID, "name": f.Name}
}); err != nil {
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
return err
}
} else {
refactor(cli): command-surface rename — session ask / doc fetch / doc create / doc delete --all Three command renames consolidate the v0.7 verb table: - `weknora agent invoke` → `weknora session ask --agent <id>`. Server route POST /sessions/{session_id}/agent-qa is session- anchored, so the verb moves with it. `weknora agent` subtree keeps CRUD only (list / view / create / edit / delete / status / check). SDK call (AgentQAStreamWithRequest) preserved verbatim; only the command surface + flag layout move. - `weknora doc upload` split into three commands: - `weknora doc upload <file>` — local file (only). - `weknora doc fetch <url>` — server-side remote fetch (was `upload --from-url`). URL-only flags (--title / --file-type / --tag-id) move with the verb. - `weknora doc create --text` — direct text knowledge entry via server CreateManualKnowledge. - `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`. Atomic server ClearKnowledgeBaseContents (no list-then-delete race). Same exit-10 -y/--yes guard as other destructive verbs; unified through the extended ConfirmDestructive helper. Parent commands (agent, kb, doc, chunk, session, auth, profile, search) lose their explicit Args:NoArgs + Run:cmd.Help so the unknown-subcommand guard fires correctly — `weknora agent invoke ag_x q` now emits the typed input.unknown_subcommand envelope with detail.available[] instead of cobra's free-form exit-2 prose. Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
2026-05-21 10:42:27 +00:00
fmt.Fprintf(iostreams.IO.Out, "Uploaded %d, Failed %d\n", len(outcomes)-failures, failures)
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
}
refactor(cli): command-surface rename — session ask / doc fetch / doc create / doc delete --all Three command renames consolidate the v0.7 verb table: - `weknora agent invoke` → `weknora session ask --agent <id>`. Server route POST /sessions/{session_id}/agent-qa is session- anchored, so the verb moves with it. `weknora agent` subtree keeps CRUD only (list / view / create / edit / delete / status / check). SDK call (AgentQAStreamWithRequest) preserved verbatim; only the command surface + flag layout move. - `weknora doc upload` split into three commands: - `weknora doc upload <file>` — local file (only). - `weknora doc fetch <url>` — server-side remote fetch (was `upload --from-url`). URL-only flags (--title / --file-type / --tag-id) move with the verb. - `weknora doc create --text` — direct text knowledge entry via server CreateManualKnowledge. - `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`. Atomic server ClearKnowledgeBaseContents (no list-then-delete race). Same exit-10 -y/--yes guard as other destructive verbs; unified through the extended ConfirmDestructive helper. Parent commands (agent, kb, doc, chunk, session, auth, profile, search) lose their explicit Args:NoArgs + Run:cmd.Help so the unknown-subcommand guard fires correctly — `weknora agent invoke ag_x q` now emits the typed input.unknown_subcommand envelope with detail.available[] instead of cobra's free-form exit-2 prose. Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
2026-05-21 10:42:27 +00:00
if runErr != nil {
// Silent on the --format json path: the success object above already
refactor(cli): command-surface rename — session ask / doc fetch / doc create / doc delete --all Three command renames consolidate the v0.7 verb table: - `weknora agent invoke` → `weknora session ask --agent <id>`. Server route POST /sessions/{session_id}/agent-qa is session- anchored, so the verb moves with it. `weknora agent` subtree keeps CRUD only (list / view / create / edit / delete / status / check). SDK call (AgentQAStreamWithRequest) preserved verbatim; only the command surface + flag layout move. - `weknora doc upload` split into three commands: - `weknora doc upload <file>` — local file (only). - `weknora doc fetch <url>` — server-side remote fetch (was `upload --from-url`). URL-only flags (--title / --file-type / --tag-id) move with the verb. - `weknora doc create --text` — direct text knowledge entry via server CreateManualKnowledge. - `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`. Atomic server ClearKnowledgeBaseContents (no list-then-delete race). Same exit-10 -y/--yes guard as other destructive verbs; unified through the extended ConfirmDestructive helper. Parent commands (agent, kb, doc, chunk, session, auth, profile, search) lose their explicit Args:NoArgs + Run:cmd.Help so the unknown-subcommand guard fires correctly — `weknora agent invoke ag_x q` now emits the typed input.unknown_subcommand envelope with detail.available[] instead of cobra's free-form exit-2 prose. Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
2026-05-21 10:42:27 +00:00
// carries per-file detail; without Silent the root error handler would
// print to stderr in addition. ExitCode still walks Code so the typed
// exit-code-by-class contract holds.
feat(cli)!: v0.10 reliability, agent-UX, and command-surface hardening A hardening + finalization pass over the agent-first CLI: correctness fixes, richer machine-readable signals, flag/naming consistency, and a symmetric config surface. Pre-1.0, so it includes breaking renames. Correctness: - agent update: resolve/validate --model/--rerank-model (was storing a bogus name verbatim, corrupting config.model_id). - doctor: honor WEKNORA_HOST / WEKNORA_API_KEY (headless path no longer reports "no host configured"). - session ask / MCP session_ask: text answer was empty on non-TTY — the agent stream sets Done=true on an intermediate agent_query frame before the answer, and AgentAccumulator treated the first Done as terminal. Terminate on the `complete` event (new sdk.AgentResponseTypeComplete), not a per-frame Done. - batch exit codes: any per-item failure collapses to operation.failed (exit 1), including `doc upload --recursive` partial failures — a permanent per-file failure (e.g. a duplicate) no longer surfaces as a retryable exit 7 an agent would loop on; per-item typed errors stay in the envelope. Agent-first signals & discovery: - error.exit_code in the envelope (type + exit_code disambiguate the input.invalid_argument exit-2-vs-5 split in one JSON read). - meta.hint on empty content search and on draft doc create; doc wait fails fast on a never-parsing draft instead of hanging to --timeout. - retrieval-readiness is visible in the natural flow: kb status / kb check emit retrieval_ready, and kb create hints the fix when no embedding model is bound — an unconfigured KB no longer looks silently healthy. - schema contract completeness: every leaf declares output + >=1 example (drift-guarded); output strings match the meta actually emitted; chunk list and search docs now emit meta.total_count (both previously dropped it). - schema tolerates a quoted multi-word command label; zero-state auth — and `link` with no profile — point at profile setup / the headless WEKNORA_KB_ID path instead of looping on `auth login`. - id-addressed reads tolerate a redundant --kb (doc view/wait, chunk list/view accept and ignore it, declared in schema) so a carried-over --kb doesn't exit 2; streaming commands warn that --jq does not apply to an NDJSON stream. - keep JSON-always as the default; --jq hints spell out the .data path. Consistency & gating: - doc create: drop the deprecated --name alias (--title only; pre-1.0 break). - chunk list --limit aligned to 1..10000; model list --limit/-L with has_more/total_count; api write-gates -X PUT/PATCH (exit 10); skills install expands a leading ~. - docs corrected: search docs / doc list --keyword help is case-insensitive (server does LOWER LIKE); AGENTS.md risk-action list (no phantom kb.init; add model.update / kb.config.set) and batch example (failed item carries `error`); session resume --message id comes from `message list`, not the stream. - auth/profile ergonomics: env credentials are now first-class — `auth token` prints the active WEKNORA_API_KEY / WEKNORA_TOKEN, and auth login/logout/refresh give an env-aware message instead of looping on "run auth login". `auth logout` clears credentials but keeps the profile registered (host preserved for re-login); deleting a profile is `profile remove`'s job (clean logout/remove separation, matching gh / lark). Config surface (symmetric read/write, in-place model edits): - kb config now returns a secret-free KBModelConfigView (was {}); `kb config` reads, new `kb config set` writes; `kb init` removed (misnomer). - kb create --chat-model: retrieval-ready in one step. - model update: edit a model in place (id preserved, references survive) — rotate --api-key-stdin, change base-url / display-name / etc. - session continue-stream renamed to session resume. Docs: AGENTS.md is the single wire-contract source; CHANGELOG slimmed; stale kb-init / continue-stream references removed; skill wire-vocab guard extended. AGENTS.md / weknora-shared SKILL document retrieval_ready (a KB needs an embedding model to be searchable), that --jq does not apply to NDJSON streams, and the env-credential-first auth path; the KB quickstart example now creates a retrieval-ready KB.
2026-07-02 07:53:51 +00:00
// Any per-file failure collapses to operation.failed (exit 1) — the
// per-file batch envelope carries each file's typed error, which is the
// authoritative signal (matches doc/session/chunk batch delete). A
// cancelled / timed-out batch keeps its context class (124 / 130) so a
// permanent partial failure (e.g. a duplicate) is never misreported as a
// retryable 5xx that an agent would loop on.
code := cmdutil.CodeOperationFailed
if ctxErr := ctx.Err(); ctxErr != nil {
code = cmdutil.ClassifyContextErr(ctxErr)
refactor(cli): command-surface rename — session ask / doc fetch / doc create / doc delete --all Three command renames consolidate the v0.7 verb table: - `weknora agent invoke` → `weknora session ask --agent <id>`. Server route POST /sessions/{session_id}/agent-qa is session- anchored, so the verb moves with it. `weknora agent` subtree keeps CRUD only (list / view / create / edit / delete / status / check). SDK call (AgentQAStreamWithRequest) preserved verbatim; only the command surface + flag layout move. - `weknora doc upload` split into three commands: - `weknora doc upload <file>` — local file (only). - `weknora doc fetch <url>` — server-side remote fetch (was `upload --from-url`). URL-only flags (--title / --file-type / --tag-id) move with the verb. - `weknora doc create --text` — direct text knowledge entry via server CreateManualKnowledge. - `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`. Atomic server ClearKnowledgeBaseContents (no list-then-delete race). Same exit-10 -y/--yes guard as other destructive verbs; unified through the extended ConfirmDestructive helper. Parent commands (agent, kb, doc, chunk, session, auth, profile, search) lose their explicit Args:NoArgs + Run:cmd.Help so the unknown-subcommand guard fires correctly — `weknora agent invoke ag_x q` now emits the typed input.unknown_subcommand envelope with detail.available[] instead of cobra's free-form exit-2 prose. Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
2026-05-21 10:42:27 +00:00
}
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
return &cmdutil.Error{
refactor(cli): command-surface rename — session ask / doc fetch / doc create / doc delete --all Three command renames consolidate the v0.7 verb table: - `weknora agent invoke` → `weknora session ask --agent <id>`. Server route POST /sessions/{session_id}/agent-qa is session- anchored, so the verb moves with it. `weknora agent` subtree keeps CRUD only (list / view / create / edit / delete / status / check). SDK call (AgentQAStreamWithRequest) preserved verbatim; only the command surface + flag layout move. - `weknora doc upload` split into three commands: - `weknora doc upload <file>` — local file (only). - `weknora doc fetch <url>` — server-side remote fetch (was `upload --from-url`). URL-only flags (--title / --file-type / --tag-id) move with the verb. - `weknora doc create --text` — direct text knowledge entry via server CreateManualKnowledge. - `weknora kb empty <id>` → `weknora doc delete --all --kb=<id>`. Atomic server ClearKnowledgeBaseContents (no list-then-delete race). Same exit-10 -y/--yes guard as other destructive verbs; unified through the extended ConfirmDestructive helper. Parent commands (agent, kb, doc, chunk, session, auth, profile, search) lose their explicit Args:NoArgs + Run:cmd.Help so the unknown-subcommand guard fires correctly — `weknora agent invoke ag_x q` now emits the typed input.unknown_subcommand envelope with detail.available[] instead of cobra's free-form exit-2 prose. Spec: docs/superpowers/specs/2026-05-20-weknora-cli-v0.7-design.md §3.4 / §10.7
2026-05-21 10:42:27 +00:00
Code: code,
Message: fmt.Sprintf("%d of %d uploads failed", failures, len(matches)),
Silent: fopts.WantsJSON(),
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
}
}
return nil
}
fix(cli): preserve directory structure in doc upload --recursive (#3753) * fix(cli): preserve directory structure in doc upload --recursive `doc upload --recursive` passed an empty customFileName to CreateKnowledgeFromFile, so every file landed in the knowledge base root and the directory tree it was asked to walk was lost. The web UI's folder upload does not have this problem -- it passes the browser-supplied relative path, which the server splits into folder_path + file_name via types.SplitKnowledgeRelativePath. Pass the path relative to the walked directory instead. Files directly under that directory still send "" so the request stays byte-identical to the previous behaviour for the common flat-directory case; only nested files gain a folder prefix. - knowledgeRelativePath() converts to forward slashes (the server splits on "/", so Windows backslashes would not separate) and returns "" for paths outside the walked root rather than leaking a "../" chain into the folder tree. - The test double previously discarded customFileName with `_,` -- which is why this could regress with the suite green. It now records the value and two tests cover the nested and flat cases. * fix(cli): reject only the parent component in knowledgeRelativePath Review feedback on the recursive-upload folder path: - `strings.HasPrefix(rel, "..")` also rejected children whose name merely starts with dots, e.g. `..drafts/report.pdf`. Replaced with a component-wise check (`rel == ".."` or `".."+separator` prefix). - Root-level files must send ""; the guard now returns "" for `filepath.Dir(rel) == "."` explicitly rather than relying on the accidental prefix match to encode that rule. Covered by a `..drafts/report.pdf` case in TestUploadRecursive_PreservesFolderStructure. * test(cli): expect an empty name for root files in knowledgeRelativePath knowledgeRelativePath returns "" for files directly under the walked root, so the test must expect that. Also wrap an over-long line. --------- Co-authored-by: wizardchen <wizardchen@tencent.com>
2026-10-08 05:13:57 +00:00
// knowledgeRelativePath returns the path of file relative to root, using
// forward slashes so the server's SplitKnowledgeRelativePath can split it
// into folder_path + file_name.
//
// A file directly under root yields "" so the request stays byte-identical to
// the pre-folder behaviour for the common "upload a flat directory" case --
// only nested files gain a folder prefix. Returns "" if file is not under
// root (defensive: walkMatches only ever yields paths under root).
func knowledgeRelativePath(root, file string) string {
rel, err := filepath.Rel(root, file)
if err != nil || rel == "." || escapesRoot(rel) || filepath.Dir(rel) == "." {
return ""
}
return filepath.ToSlash(rel)
}
// escapesRoot reports whether rel is the parent directory or a path under it.
// The check is component-wise, not a ".." prefix match: a legitimate child
// like "..drafts/report.pdf" starts with ".." but is still inside root.
func escapesRoot(rel string) bool {
return rel == ".." || strings.HasPrefix(rel, ".."+string(filepath.Separator))
}
feat(cli): doc download + upload --recursive Roadmap items 3-9 (download) and 3-10 (recursive upload). SDK addition (additive, non-breaking): - OpenKnowledgeFile(ctx, id) (filename, body io.ReadCloser, err) — the new primitive that returns the body as a stream plus the server-suggested Content-Disposition filename. The existing path- form DownloadKnowledgeFile is now a thin wrapper (also gained partial-file-on-error cleanup, a pre-existing bug exposed by the reshape). doc download <id>: Borrows shape from `gh release download` (positional id, output flag, `-` sentinel for stdout). Flag names match gh canon verified against the gh manual: `-O, --output <file>` for destination; `--clobber` for overwrite control. - Default: writes to cwd under the server-suggested filename. If the server didn't send one, errors with input.missing_flag. - --output FILE / -O FILE: writes to FILE. Refuses overwrite without --clobber. - --output -: stream to stdout (binary-safe). - Partial writes on error are cleaned up. doc upload --recursive <dir> --glob '*.pdf': NOTE on upstream parity: `gh release upload` does NOT support --recursive (verified — it takes individual file args only). `aws s3 cp --recursive` does, but uses `--include`/`--exclude` glob pattern pairs rather than a single `--glob`. weknora's single positive `--glob` is a deliberate simplification, not a direct mirror of either tool. - Walks the tree, filters by base-name glob, uploads each match sequentially. Per-file line output: OK / FAIL with the underlying error. Exit 0 only on full success; on partial failure returns the first failure's typed code so callers can branch. Rejects --name with --recursive. - --dry-run lists matches without uploading. - --json emits {kb_id, uploaded[], failed[]} envelope at completion. Bugs caught in the post-commit reviewer round: - SECURITY: server-supplied filename was used in os.Rename without sanitization. A malicious / buggy server returning "../../etc/shadow" could escape cwd. Now filepath.Base'd; "." / "/" / "" rejected. Regression test added. - Wasted-bytes path eliminated via the SDK reshape: the CLI now inspects filename and applies refuseIfExists BEFORE streaming. Two-phase temp+rename gone. - refuseIfExists(path, clobber) helper extracted. - --json honored in --recursive (uploadOutcome was JSON-tagged but the envelope was never emitted). 7 + 7 unit tests for download (+ path-traversal regression) and recursive upload (+ JSON envelope regression). Roadmap: 3-9, 3-10.
2026-05-12 15:36:34 +00:00
// walkMatches returns every regular file under root whose base name matches
// pattern. Order is filepath.WalkDir's lexical order (stdlib guarantee on
// every supported FS), which is deterministic for test assertions.
func walkMatches(root, pattern string) ([]string, error) {
var out []string
err := filepath.WalkDir(root, func(p string, d fs.DirEntry, err error) error {
if err != nil {
return err
}
if d.IsDir() {
return nil
}
// Skip non-regular files (sockets, devices); the SDK can't upload
// them and they'd show as opaque server errors.
info, ierr := d.Info()
if ierr != nil {
return ierr
}
if !info.Mode().IsRegular() {
return nil
}
ok, merr := filepath.Match(pattern, d.Name())
if merr != nil {
return merr
}
if ok {
out = append(out, p)
}
return nil
})
if err != nil {
return nil, err
}
return out, nil
}