WeKnora/internal/handler/session/workspace_checkpoint_comple...

152 lines
4.9 KiB
Go

package session
import (
"context"
"errors"
"strings"
"testing"
"time"
"github.com/Tencent/WeKnora/internal/application/service"
"github.com/Tencent/WeKnora/internal/event"
"github.com/Tencent/WeKnora/internal/sandbox"
"github.com/Tencent/WeKnora/internal/types"
"github.com/Tencent/WeKnora/internal/types/interfaces"
"github.com/stretchr/testify/require"
)
type stubShellRunner struct {
stdout string
exitCode int
err error
calls int
}
func (s *stubShellRunner) ExecShellCommand(
_ context.Context, _ string, _, _ string, _ time.Duration, _ map[string]string,
) (*sandbox.ExecuteResult, error) {
s.calls++
if s.err != nil {
return nil, s.err
}
return &sandbox.ExecuteResult{ExitCode: s.exitCode, Stdout: s.stdout}, nil
}
type stubSandboxIDLookup struct {
id string
ok bool
}
func (s stubSandboxIDLookup) BoundSandboxID(context.Context, string) (string, bool) {
return s.id, s.ok
}
func newCheckpointHandler(
t *testing.T, runner service.SandboxShellRunner, lookup SandboxIDLookup,
) (*AgentStreamHandler, *types.Message) {
t.Helper()
message := &types.Message{ID: "m1", SessionID: "s1", Role: "assistant"}
h := NewAgentStreamHandler(
context.Background(), "s1", "m1", "req1", 1, time.Now(),
message, &completionEventRecorder{}, event.NewEventBus(), nil,
service.NewWorkspaceCheckpointer(runner), lookup,
)
return h, message
}
func completeEvent() event.Event {
return event.Event{Data: event.AgentCompleteData{MessageID: "m1", FinalAnswer: "done"}}
}
func TestHandleCompleteRecordsCheckpoint(t *testing.T) {
runner := &stubShellRunner{stdout: strings.Repeat("a", 40) + "\n"}
h, message := newCheckpointHandler(t, runner, stubSandboxIDLookup{id: "sbx-1", ok: true})
require.NoError(t, h.handleComplete(context.Background(), completeEvent()))
require.Equal(t, 1, runner.calls)
require.NotNil(t, message.SandboxCheckpoint)
require.Equal(t, "sbx-1", message.SandboxCheckpoint.SandboxID)
require.Equal(t, strings.Repeat("a", 40), message.SandboxCheckpoint.CommitSHA)
}
// A failed checkpoint must never disturb the reply: the message still
// completes, it just carries no checkpoint and cannot serve as a fork point.
func TestHandleCompleteSurvivesCheckpointFailure(t *testing.T) {
runner := &stubShellRunner{err: errors.New("sandbox unreachable")}
h, message := newCheckpointHandler(t, runner, stubSandboxIDLookup{id: "sbx-1", ok: true})
require.NoError(t, h.handleComplete(context.Background(), completeEvent()))
require.Nil(t, message.SandboxCheckpoint)
require.True(t, message.IsCompleted)
}
func TestHandleCompleteSkipsCheckpointWithoutBoundSandbox(t *testing.T) {
runner := &stubShellRunner{stdout: strings.Repeat("a", 40) + "\n"}
h, message := newCheckpointHandler(t, runner, stubSandboxIDLookup{ok: false})
require.NoError(t, h.handleComplete(context.Background(), completeEvent()))
require.Zero(t, runner.calls)
require.Nil(t, message.SandboxCheckpoint)
}
func TestHandleCompleteWorksWithoutCheckpointerWired(t *testing.T) {
message := &types.Message{ID: "m1", SessionID: "s1", Role: "assistant"}
h := NewAgentStreamHandler(
context.Background(), "s1", "m1", "req1", 1, time.Now(),
message, &completionEventRecorder{}, event.NewEventBus(), nil, nil, nil,
)
require.NoError(t, h.handleComplete(context.Background(), completeEvent()))
require.Nil(t, message.SandboxCheckpoint)
}
type capturingMessageService struct {
interfaces.MessageService
content string
checkpoint *types.SandboxCheckpoint
}
func (s *capturingMessageService) UpdateMessage(_ context.Context, message *types.Message) error {
if message == nil {
return nil
}
s.content = message.Content
if message.SandboxCheckpoint != nil {
cp := *message.SandboxCheckpoint
s.checkpoint = &cp
}
return nil
}
func (s *capturingMessageService) IndexMessageToKB(context.Context, string, string, string, string) {}
func TestQuickAnswerCompletionPersistsSandboxCheckpoint(t *testing.T) {
runner := &stubShellRunner{stdout: strings.Repeat("a", 40) + "\n"}
bus := event.NewEventBus()
message := &types.Message{
ID: "m1", SessionID: "s1", Role: "assistant", Content: "hello from quick answer",
}
streamHandler := NewAgentStreamHandler(
context.Background(), "s1", "m1", "req1", 1, time.Now(),
message, &completionEventRecorder{}, bus,
nil, service.NewWorkspaceCheckpointer(runner), stubSandboxIDLookup{id: "sbx-1", ok: true},
)
streamHandler.Subscribe()
stub := &capturingMessageService{}
h := &Handler{messageService: stub}
h.completeQuickAnswerTurn(context.Background(), &sseStreamContext{
eventBus: bus,
assistantMessage: message,
}, "", "")
require.Equal(t, 1, runner.calls, "quick-answer complete must checkpoint before persist")
require.NotNil(t, stub.checkpoint, "UpdateMessage must see SandboxCheckpoint")
require.Equal(t, "sbx-1", stub.checkpoint.SandboxID)
require.Equal(t, strings.Repeat("a", 40), stub.checkpoint.CommitSHA)
require.Equal(t, "hello from quick answer", stub.content, "complete event must not re-append the answer")
}